New Admin UI - Card Component #4405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into adrian/remaining-tokens-card # Conflicts: # packages/admin-ui/src/Card/Card.stories.tsx
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is targeting
feat/containertemporarily. Once that one is merged, it'll targetnew-admin-uibranch again. This happened because I wanted to useContainer(in SB stories), in order to restrict the width of the card, which is by default fluid (as agreed with Kreso).In hindsight, I could've probably kept it simple and just use a couple of TW classes to restrict the width of the Card. But yeah... realized that when it was too late. 🙃
Changes
This PR introduces the Card component.
Extra Changes
With Kreso, we introduced an additional button variant. Basically an icon-only button, with a larger icon in it. This is utilized in the Card component, here:
Note that I've added an additional story within the Button section in SB.
How Has This Been Tested?
Manually.