webiny · brunozoric · Aug 27, 2024 · Aug 28, 2024
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -38,7 +38,12 @@ module.exports = {
                 "ts-expect-error": false
             }
         ],
-        "@typescript-eslint/ban-types": "error",
+        "@typescript-eslint/no-empty-object-type": "error",
+        "@typescript-eslint/no-unsafe-function-type": "error",
+        "@typescript-eslint/no-wrapper-object-types": "error",
+        "@typescript-eslint/no-duplicate-enum-values": 0,
+        "@typescript-eslint/no-unused-expressions": 0,
+        "@typescript-eslint/no-require-imports": 0,
         "@typescript-eslint/no-use-before-define": 0,
         "@typescript-eslint/no-unused-vars": getNoUnusedVars(),
         "@typescript-eslint/no-var-requires": 0,

diff --git a/cypress-tests/cypress/support/pageBuilder/reloadUntil.ts b/cypress-tests/cypress/support/pageBuilder/reloadUntil.ts
@@ -54,7 +54,7 @@ Cypress.Commands.add("reloadUntil", (callback, options = {}) => {
                         }
                     }
                     return cy.log("Condition met, moving on...");
-                } catch (err) {
+                } catch {
                     if (retries > MAX_RETRIES) {
                         throw new Error(`retried too many times (${--retries})`);
                     }

diff --git a/cypress-tests/cypress/support/reloadUntil/index.js b/cypress-tests/cypress/support/reloadUntil/index.js
@@ -43,7 +43,7 @@ Cypress.Commands.add("reloadUntil", (callback, options = {}) => {
                         }
                     }
                     return cy.log("Condition met, moving on...");
-                } catch (err) {
+                } catch {
                     if (retries > MAX_RETRIES) {
                         throw new Error(`retried too many times (${--retries})`);
                     }

diff --git a/cypress-tests/package.json b/cypress-tests/package.json
@@ -19,7 +19,7 @@
     "lodash": "^4.17.21",
     "nanoid": "^3.3.7",
     "node-fetch": "^2.6.1",
-    "typescript": "4.9.5",
+    "typescript": "5.1.6",
     "uniqid": "^5.2.0"
   },
   "scripts": {

diff --git a/package.json b/package.json
@@ -41,8 +41,8 @@
     "@types/prettier": "^2.7.3",
     "@types/react": "18.2.79",
     "@types/react-dom": "18.2.25",
-    "@typescript-eslint/eslint-plugin": "^5.5.0",
-    "@typescript-eslint/parser": "^5.5.0",
+    "@typescript-eslint/eslint-plugin": "^8.3.0",
+    "@typescript-eslint/parser": "^8.3.0",
     "adio": "^1.0.1",
     "babel-jest": "29.7.0",
     "babel-plugin-dynamic-import-node": "2.3.3",
@@ -93,9 +93,10 @@
     "rimraf": "^5.0.5",
     "semver": "^7.5.4",
     "ts-expect": "^1.3.0",
-    "ts-jest": "^29.1.2",
-    "typescript": "4.9.5",
-    "typescript-transform-paths": "^3.4.6",
+    "ts-jest": "^29.2.5",
+    "ts-patch": "^3.2.1",
+    "typescript": "5.1.6",
+    "typescript-transform-paths": "^3.5.0",
     "verdaccio": "^5.29.1",
     "write-json-file": "^4.2.0",
     "yargs": "^17.0.1"
@@ -134,7 +135,7 @@
     "trigger-release": "node ./scripts/release/triggerRelease.js",
     "dispatch-github-event": "node ./scripts/dispatchGitHubEvent.js",
     "lint-staged": "lint-staged",
-    "postinstall": "yarn node ./scripts/linkWorkspaces.js",
+    "postinstall": "ts-patch install -s && yarn node ./scripts/linkWorkspaces.js",
     "prepublishOnly": "node scripts/prepublishOnly",
     "prettier": "prettier \"**/**/*.{js,jsx,ts,tsx,json,scss}\" --config .prettierrc.js",
     "prettier:check": "yarn prettier --check",

diff --git a/packages/api-aco/package.json b/packages/api-aco/package.json
@@ -56,7 +56,7 @@
     "graphql": "^15.8.0",
     "prettier": "^2.8.3",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.13",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   }
 }
diff --git a/packages/api-admin-settings/package.json b/packages/api-admin-settings/package.json
@@ -40,8 +40,8 @@
     "prettier": "^2.8.3",
     "rimraf": "^5.0.5",
     "sinon": "^9.0.2",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-admin-users-so-ddb/package.json b/packages/api-admin-users-so-ddb/package.json
@@ -30,8 +30,8 @@
     "jest": "^29.7.0",
     "jest-dynalite": "^3.2.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-admin-users/package.json b/packages/api-admin-users/package.json
@@ -36,7 +36,7 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "typescript": "4.9.5"
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-apw-scheduler-so-ddb/package.json b/packages/api-apw-scheduler-so-ddb/package.json
@@ -40,8 +40,8 @@
     "jest": "^29.7.0",
     "jest-dynalite": "^3.2.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-apw/package.json b/packages/api-apw/package.json
@@ -54,8 +54,8 @@
     "prettier": "^2.8.3",
     "rimraf": "^5.0.5",
     "sinon": "^9.0.2",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-apw/src/plugins/hooks/validateComment.ts b/packages/api-apw/src/plugins/hooks/validateComment.ts
@@ -20,7 +20,7 @@ export const validateComment = ({ apw }: Pick<LifeCycleHookCallbackParams, "apw"
                     }
                 );
             }
-        } catch (ex) {
+        } catch {
             throw new WebinyError(
                 `The"changeRequest" property in input is not properly formatted.`,
                 "MALFORMED_CHANGE_REQUEST_ID",

diff --git a/packages/api-audit-logs/package.json b/packages/api-audit-logs/package.json
@@ -37,8 +37,8 @@
     "@webiny/plugins": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "graphql": "^15.8.0",
-    "ttypescript": "^1.5.13",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "dependencies": {
     "@webiny/api": "0.0.0",

diff --git a/packages/api-audit-logs/src/subscriptions/index.ts b/packages/api-audit-logs/src/subscriptions/index.ts
@@ -18,5 +18,8 @@ export const createSubscriptionHooks = (context: AuditLogsContext) => {
     createI18NHooks(context);
     createMailerHooks(context);
     createAcoHooks(context);
-    context.wcp.canUseFeature("advancedPublishingWorkflow") && createApwHooks(context);
+    if (!context.wcp.canUseFeature("advancedPublishingWorkflow")) {
+        return;
+    }
+    createApwHooks(context);
 };
diff --git a/packages/api-authentication-cognito/package.json b/packages/api-authentication-cognito/package.json
@@ -22,7 +22,7 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "typescript": "4.9.5"
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-authentication/package.json b/packages/api-authentication/package.json
@@ -26,8 +26,8 @@
     "@webiny/project-utils": "0.0.0",
     "jest-dynalite": "^3.2.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-background-tasks-ddb/package.json b/packages/api-background-tasks-ddb/package.json
@@ -19,8 +19,8 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-background-tasks-es/package.json b/packages/api-background-tasks-es/package.json
@@ -21,8 +21,8 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-background-tasks-os/package.json b/packages/api-background-tasks-os/package.json
@@ -21,8 +21,8 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-cognito-authenticator/package.json b/packages/api-cognito-authenticator/package.json
@@ -25,7 +25,7 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "typescript": "4.9.5"
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-dynamodb-to-elasticsearch/package.json b/packages/api-dynamodb-to-elasticsearch/package.json
@@ -29,7 +29,7 @@
     "@webiny/cli": "0.0.0",
     "@webiny/plugins": "0.0.0",
     "@webiny/project-utils": "0.0.0",
-    "typescript": "4.9.5"
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-elasticsearch-tasks/package.json b/packages/api-elasticsearch-tasks/package.json
@@ -40,9 +40,9 @@
     "@webiny/plugins": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.13",
+    "ts-patch": "3.2.1",
     "type-fest": "^2.19.0",
-    "typescript": "4.9.5"
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-elasticsearch/package.json b/packages/api-elasticsearch/package.json
@@ -26,8 +26,8 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-elasticsearch/src/plugins/GzipCompression.ts b/packages/api-elasticsearch/src/plugins/GzipCompression.ts
@@ -60,7 +60,7 @@ class GzipCompression extends CompressionPlugin {
             const buf = await ungzip(convertToBuffer(data.value));
             const value = buf.toString(FROM_STORAGE_ENCODING);
             return JSON.parse(value);
-        } catch (ex) {
+        } catch {
             return null;
         }
     }

diff --git a/packages/api-elasticsearch/src/utils/createIndex.ts b/packages/api-elasticsearch/src/utils/createIndex.ts
@@ -39,6 +39,7 @@ const indexExists = async (params: ExistsIndexParams): Promise<boolean> => {
         return true;
     } catch (ex) {
         console.error(`Could not determine if the index "${index}" exists.`);
+        console.log(ex);
     }
     return false;
 };

diff --git a/packages/api-file-manager-ddb/package.json b/packages/api-file-manager-ddb/package.json
@@ -40,8 +40,8 @@
     "jest-dynalite": "^3.2.0",
     "jsonpack": "^1.1.5",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-file-manager-ddb/src/operations/SystemStorageOperations.ts b/packages/api-file-manager-ddb/src/operations/SystemStorageOperations.ts
@@ -72,6 +72,7 @@ export class SystemStorageOperations implements FileManagerSystemStorageOperatio
                 "Could not insert new system data into DynamoDB",
                 "CREATE_SYSTEM_ERROR",
                 {
+                    ...ex.data,
                     data
                 }
             );
@@ -98,6 +99,7 @@ export class SystemStorageOperations implements FileManagerSystemStorageOperatio
                 "Could not update system data in the DynamoDB.",
                 "UPDATE_SYSTEM_ERROR",
                 {
+                    ...ex.data,
                     data
                 }
             );

diff --git a/packages/api-file-manager-s3/package.json b/packages/api-file-manager-s3/package.json
@@ -37,7 +37,7 @@
     "@webiny/cli": "0.0.0",
     "@webiny/project-utils": "0.0.0",
     "rimraf": "^5.0.5",
-    "typescript": "4.9.5"
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-file-manager-s3/src/assetDelivery/s3/SharpTransform.ts b/packages/api-file-manager-s3/src/assetDelivery/s3/SharpTransform.ts
@@ -64,7 +64,7 @@ export class SharpTransform implements AssetTransformationStrategy {
                 const buffer = Buffer.from(await Body.transformToByteArray());
 
                 asset.setContentsReader(new CallableContentsReader(() => buffer));
-            } catch (e) {
+            } catch {
                 const optimizedImage = await this.optimizeAsset(asset);
 
                 const widths = new WidthCollection(this.params.imageResizeWidths);
@@ -115,7 +115,7 @@ export class SharpTransform implements AssetTransformationStrategy {
             const buffer = Buffer.from(await Body.transformToByteArray());
 
             asset.setContentsReader(new CallableContentsReader(() => buffer));
-        } catch (e) {
+        } catch {
             // If not found, create an optimized version of the original asset.
             const buffer = await asset.getContents();
 

diff --git a/packages/api-file-manager-s3/src/utils/getPresignedPostPayload.ts b/packages/api-file-manager-s3/src/utils/getPresignedPostPayload.ts
@@ -10,7 +10,7 @@ const sanitizeFileSizeValue = (value: number, defaultValue: number): number => {
     try {
         validation.validateSync(value, "required,numeric,gte:0");
         return value;
-    } catch (e) {
+    } catch {
         // TODO @ts-refactor No need to log the error?
         return defaultValue;
     }

diff --git a/packages/api-file-manager/package.json b/packages/api-file-manager/package.json
@@ -45,14 +45,13 @@
     "@babel/plugin-transform-runtime": "^7.24.0",
     "@babel/preset-env": "^7.24.0",
     "@babel/preset-typescript": "^7.23.3",
-    "@types/sharp": "^0.32.0",
     "@webiny/api-i18n": "0.0.0",
     "@webiny/cli": "0.0.0",
     "@webiny/utils": "0.0.0",
     "jest": "^29.7.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/api-file-manager/src/createFileManager/system.crud.ts b/packages/api-file-manager/src/createFileManager/system.crud.ts
@@ -43,6 +43,7 @@ export const createSystemCrud = ({
                         "Could not update the system data.",
                         "SYSTEM_UPDATE_ERROR",
                         {
+                            ...ex.data,
                             data
                         }
                     );
@@ -60,6 +61,7 @@ export const createSystemCrud = ({
                 return;
             } catch (ex) {
                 throw new WebinyError("Could not create the system data.", "SYSTEM_CREATE_ERROR", {
+                    ...ex.data,
                     data
                 });
             }

diff --git a/...es/api-file-manager/src/delivery/AssetDelivery/privateFiles/PrivateFilesAssetProcessor.ts b/...es/api-file-manager/src/delivery/AssetDelivery/privateFiles/PrivateFilesAssetProcessor.ts
@@ -47,7 +47,7 @@ export class PrivateFilesAssetProcessor implements AssetProcessor {
 
         try {
             await this.assetAuthorizer.authorize(file);
-        } catch (error) {
+        } catch {
             asset.setOutputStrategy(new NotAuthorizedOutputStrategy());
 
             return asset;

diff --git a/packages/api-form-builder-so-ddb-es/package.json b/packages/api-form-builder-so-ddb-es/package.json
@@ -51,8 +51,8 @@
     "jest": "^29.7.0",
     "jest-dynalite": "^3.2.0",
     "rimraf": "^5.0.5",
-    "ttypescript": "^1.5.12",
-    "typescript": "4.9.5"
+    "ts-patch": "3.2.1",
+    "typescript": "5.1.6"
   },
   "publishConfig": {
     "access": "public",