fix(serverless-aws-s3): remove credentials from client instantiation

webiny · Jul 14, 2020 · fc87f37 · fc87f37
1 parent 43528da
commit fc87f37
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/packages/serverless-aws-s3/serverless.js b/packages/serverless-aws-s3/serverless.js
@@ -24,7 +24,7 @@ class AwsS3 extends Component {
 
         this.context.instance.debug(`Deploying bucket %o in region %o`, config.name, config.region);
 
-        const clients = getClients(this.context.instance.credentials.aws, config.region);
+        const clients = getClients(config.region);
         await ensureBucket(clients.regular, config.name, this.context.instance.debug);
 
         if (config.accelerated) {
@@ -59,10 +59,6 @@ class AwsS3 extends Component {
             );
         }
 
-        if (config.upload) {
-            await this.upload({ bucket: config.name, region: config.region, files: config.upload });
-        }
-
         this.state.name = config.name;
         this.state.region = config.region;
         this.state.accelerated = config.accelerated;

diff --git a/packages/serverless-aws-s3/utils.js b/packages/serverless-aws-s3/utils.js
@@ -13,11 +13,8 @@ const { green } = require("chalk");
 
 const PRETRY_ARGS = { retries: 3 };
 
-const getClients = (credentials, region) => {
-    const params = {
-        region,
-        credentials
-    };
+const getClients = region => {
+    const params = { region };
 
     // we need two S3 clients because creating/deleting buckets
     // is not available with the acceleration feature.