Add telemetry for URL logging #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
reviewed
Jun 23, 2020
| const configureFallbacks = (app) => { | ||
| app.use(trackUrlTelemetry); |
There was a problem hiding this comment.
IIRC, this will only send telemetry for static assets. Is this what you want?
There was a problem hiding this comment.
@molant Yes, that should be okay. We are mainly interested in tracking the documentation urls.
There was a problem hiding this comment.
We already have google analytics and can get this information (and more) from there. Is the plan to remove GA?
There was a problem hiding this comment.
@molant Not sure about GA, we can remove if it is redundant. This is to mainly to track referrals (like when "learn more" is clicked from DevTools panel). Having it in AI lets us pull it for internal reporting as well.
antross
reviewed
Jul 21, 2020
sarvaje
force-pushed
the
learn-more-telemetry
branch
from
50b07f4 to
45c0ef9
Compare
added 2 commits
July 29, 2020 20:43
Closed
antross
approved these changes
Jul 30, 2020
antross
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will track URLs from visits to webhint.io and also any referrers, which is contained within query param "source".