Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An in-range update of typescript-eslint-parser is breaking the build 🚨 #1468

Closed
greenkeeper bot opened this issue Oct 31, 2018 · 3 comments
Closed

An in-range update of typescript-eslint-parser is breaking the build 🚨 #1468

greenkeeper bot opened this issue Oct 31, 2018 · 3 comments
Assignees
@molant
Milestone
1811-1

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Oct 31, 2018

The devDependency typescript-eslint-parser was updated from 20.0.0 to 20.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

typescript-eslint-parser is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/appveyor/branch: Waiting for AppVeyor build to complete (Details).
  • ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).
Release Notes for v20.1.0
Commits

The new version differs by 6 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 31, 2018

After pinning to 20.0.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@alrra alrra closed this as completed in 5d43322 Oct 31, 2018
alrra added a commit that referenced this issue Oct 31, 2018
@alrra
Chore: Update typescript-eslint-parser to v20.1.0
8aac124 
Fix #1468
@alrra alrra reopened this Oct 31, 2018
@alrra
Copy link
Contributor

alrra commented Oct 31, 2018

There are some linting issues that appear after the upgrade that need to be addressed.

@alrra alrra mentioned this issue Oct 31, 2018
Closed
alrra added a commit that referenced this issue Oct 31, 2018
@alrra
Chore: Pin typescript-eslint-parser to v20.0.0
bf1a6cf 
Ref #1468
@molant molant added this to the 1811-1 milestone Nov 1, 2018
@molant molant mentioned this issue Nov 2, 2018
Closed
2 tasks
@molant molant self-assigned this Nov 2, 2018
@alrra alrra closed this as completed in 0072b37 Nov 2, 2018
@alrra alrra reopened this Nov 2, 2018
@alrra
Copy link
Contributor

alrra commented Nov 2, 2018

Version 20.1.0 has some issues:

See: eslint/typescript-eslint-parser#535.

@molant molant closed this as completed in c08de3c Nov 2, 2018
alrra pushed a commit that referenced this issue Nov 5, 2018
@molant @alrra
Chore: Disable ESLint rule no-redeclare
db92e29 
There are issues with this rule and `typescript-eslint-parser`
`v20.1.0` and later¹. Because `var` is not used through the code,
this rule can be safely disabled, avoid the false positives and
stil use the latest version of the parser.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

¹ eslint/typescript-eslint-parser#535

Fix #1468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molant molant

Labels
None yet
Projects
None yet
Milestone
1811-1
Development

Successfully merging a pull request may close this issue.

Chore: Update typescript-eslint-parser to v20.1.1
2 participants
@molant @alrra