Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #147

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Update README.md #147

merged 2 commits into from
Nov 25, 2022

Conversation

kjarkur
Copy link
Contributor

@kjarkur kjarkur commented Oct 31, 2022

update actions/checkout to v3 and make it syntactically correct in order to allow copy and paste

kjarkur and others added 2 commits October 31, 2022 10:48
update actions/checkout to v3 and make it syntactically correct in order to allow copy and paste
@mpdude mpdude merged commit 18ff706 into webfactory:master Nov 25, 2022
@mpdude
Copy link
Member

mpdude commented Nov 25, 2022

Indeed a valuable observation and useful for improving DX (developer experience). Thank you!

renovate bot referenced this pull request in valora-inc/wallet Aug 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [webfactory/ssh-agent](https://togithub.com/webfactory/ssh-agent) |
action | minor | `v0.5.3` -> `v0.8.0` |

---

### Release Notes

<details>
<summary>webfactory/ssh-agent (webfactory/ssh-agent)</summary>

###
[`v0.8.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.8.0):
SSH host keys no longer managed – read below 👇

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.7.0...v0.8.0)

Starting with this release, this action no longer writes GitHub's SSH
host keys into the `known_hosts` SSH config file upon start.

GitHub changed their host keys on short notice this morning, see
https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. We took
this as an opportunity to stop maintaining GH SSH keys in the code
shipped with this action
([#&#8203;171](https://togithub.com/webfactory/ssh-agent/issues/171)).

What you need to do:

- On GitHub hosted runners, nothing. ✔︎ These runners ship with SSH host
keys (for `github.com`) maintained by directly by GitHub.
-   On self-hosted runners, review and fix your SSH `known_hosts` file:
- First, you'll find it bloated with redundant entries for `github.com`,
as described in
[#&#8203;106](https://togithub.com/webfactory/ssh-agent/issues/106).
Remove these entries.
- Review
https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. You
probably removed the old (invalid) SSH key in the previous step.
- Configure GitHub's current SSH keys as documented on
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints
- As long as versions before `v0.8.0` of this action here are run on the
self-hosted runner, the old entries will come back. Keep an eye on it,
possibly you'll have to rinse & repeat.

##### Other code changes in this release

- Update to `actions/checkout@v3` by
[@&#8203;mpdude](https://togithub.com/mpdude) in
[https://github.com/webfactory/ssh-agent/pull/143](https://togithub.com/webfactory/ssh-agent/pull/143)
- Allow the user to override the commands for `git`, `ssh-agent`, and
`ssh-add` by [@&#8203;DilumAluthge](https://togithub.com/DilumAluthge)
in
[https://github.com/webfactory/ssh-agent/pull/154](https://togithub.com/webfactory/ssh-agent/pull/154)

##### New Contributors

- [@&#8203;prhiggins](https://togithub.com/prhiggins) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/153](https://togithub.com/webfactory/ssh-agent/pull/153)
- [@&#8203;kjarkur](https://togithub.com/kjarkur) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/147](https://togithub.com/webfactory/ssh-agent/pull/147)
- [@&#8203;DilumAluthge](https://togithub.com/DilumAluthge) made their
first contribution in
[https://github.com/webfactory/ssh-agent/pull/154](https://togithub.com/webfactory/ssh-agent/pull/154)

**Full Changelog**:
webfactory/ssh-agent@v0.7.0...v0.8.0

###
[`v0.7.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v070-2022-10-19)

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.6.0...v0.7.0)

##### Added

- Add the `log-public-key` input that can be used to turn off logging
key identities
([#&#8203;122](https://togithub.com/webfactory/ssh-agent/issues/122))

##### Fixed

- Fix path to `git` binary on Windows, assuming GitHub-hosted runners
([#&#8203;136](https://togithub.com/webfactory/ssh-agent/issues/136),
[#&#8203;137](https://togithub.com/webfactory/ssh-agent/issues/137))
- Fix a nonsensical log message
([#&#8203;139](https://togithub.com/webfactory/ssh-agent/issues/139))

###
[`v0.6.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v060-2022-10-19)

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.5.4...v0.6.0)

##### Changed

- Update the version of Node used by the action from 12 to 16
(https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/).

###
[`v0.5.4`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v054-2021-11-21)

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.5.3...v0.5.4)

##### Fixed

- Update changed GitHub Host Keys
([#&#8203;102](https://togithub.com/webfactory/ssh-agent/issues/102),
[#&#8203;101](https://togithub.com/webfactory/ssh-agent/issues/101))

##### Changed

-   Various documentation (README) improvements and additions
- Change logging to more precisely state that *public* keys are being
printed

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kdy1 referenced this pull request in swc-project/swc Jul 22, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [balazsorban44/nissuer](https://togithub.com/balazsorban44/nissuer) |
action | minor | `1.7.3` -> `1.10.0` |
| [webfactory/ssh-agent](https://togithub.com/webfactory/ssh-agent) |
action | minor | `v0.5.4` -> `v0.9.0` |

---

### Release Notes

<details>
<summary>balazsorban44/nissuer (balazsorban44/nissuer)</summary>

###
[`v1.10.0`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.10.0)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.3...1.10.0)

**Full Changelog**:
balazsorban44/nissuer@1.9.3...1.10.0

###
[`v1.9.3`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.3)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.2...1.9.3)

**Full Changelog**:
balazsorban44/nissuer@1.9.2...1.9.3

###
[`v1.9.2`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.2)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.1...1.9.2)

**Full Changelog**:
balazsorban44/nissuer@1.9.1...1.9.2

###
[`v1.9.1`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.1)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.0...1.9.1)

**Full Changelog**:
balazsorban44/nissuer@1.9.0...1.9.1

###
[`v1.9.0`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.0)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.8.2...1.9.0)

**Full Changelog**:
balazsorban44/nissuer@1.8.2...1.9.0

###
[`v1.8.2`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.8.2)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.8.1...1.8.2)

**Full Changelog**:
balazsorban44/nissuer@1.8.1...1.8.2

###
[`v1.8.1`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.8.1)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.8.0...1.8.1)

Fix https://github.com/balazsorban44/nissuer/releases/tag/1.8.0 by
actually shipping the built version

###
[`v1.8.0`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.8.0)

[Compare
Source](https://togithub.com/balazsorban44/nissuer/compare/1.7.3...1.8.0)

#### Features

- do not hide comments from organization members
([`2d5aa95`](https://togithub.com/balazsorban44/nissuer/commit/2d5aa95))
- add blocklist option
([`eb4bf4b`](https://togithub.com/balazsorban44/nissuer/commit/eb4bf4b))
- **docs:** update readme and action
([`6163c40`](https://togithub.com/balazsorban44/nissuer/commit/6163c40))

#### Other changes

- bump dependencies
([`6114e48`](https://togithub.com/balazsorban44/nissuer/commit/6114e48))

</details>

<details>
<summary>webfactory/ssh-agent (webfactory/ssh-agent)</summary>

###
[`v0.9.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.9.0):
Update to `node20`

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.8.0...v0.9.0)

This release updates the action to run on Node.js v20. When you're
running on GitHub hosted runners, just go ahead and update. When you're
using self-hosted runners, please make sure you have Node.js v20
installed before updating from `v0.8.0` to `v0.9.0` of this action.

#### New Contributors

- [@&#8203;npwolf](https://togithub.com/npwolf) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196)
- [@&#8203;benzado](https://togithub.com/benzado) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206)
- [@&#8203;felix-seifert](https://togithub.com/felix-seifert) made their
first contribution in
[https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199)
- [@&#8203;archen](https://togithub.com/archen) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201)

**Full Changelog**:
webfactory/ssh-agent@v0.8.0...v0.9.0

#### What's Changed

- Update README.md to reflect latest version by
[@&#8203;npwolf](https://togithub.com/npwolf) in
[https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196)
- Remove outdated claim from README by
[@&#8203;benzado](https://togithub.com/benzado) in
[https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206)
- chore: update all versions of `actions/checkout` to v4 by
[@&#8203;felix-seifert](https://togithub.com/felix-seifert) in
[https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199)
- bump to node20 by [@&#8203;archen](https://togithub.com/archen) in
[https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201)

#### New Contributors

- [@&#8203;npwolf](https://togithub.com/npwolf) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196)
- [@&#8203;benzado](https://togithub.com/benzado) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206)
- [@&#8203;felix-seifert](https://togithub.com/felix-seifert) made their
first contribution in
[https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199)
- [@&#8203;archen](https://togithub.com/archen) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201)

**Full Changelog**:
webfactory/ssh-agent@v0.8.0...v0.9.0

###
[`v0.8.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.8.0):
SSH host keys no longer managed – read below 👇

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.7.0...v0.8.0)

Starting with this release, this action no longer writes GitHub's SSH
host keys into the `known_hosts` SSH config file upon start.

GitHub changed their host keys on short notice this morning, see
https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. We took
this as an opportunity to stop maintaining GH SSH keys in the code
shipped with this action
([#&#8203;171](https://togithub.com/webfactory/ssh-agent/issues/171)).

What you need to do:

- On GitHub hosted runners, nothing. ✔︎ These runners ship with SSH host
keys (for `github.com`) maintained by directly by GitHub.
-   On self-hosted runners, review and fix your SSH `known_hosts` file:
- First, you'll find it bloated with redundant entries for `github.com`,
as described in
[#&#8203;106](https://togithub.com/webfactory/ssh-agent/issues/106).
Remove these entries.
- Review
https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. You
probably removed the old (invalid) SSH key in the previous step.
- Configure GitHub's current SSH keys as documented on
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints
- As long as versions before `v0.8.0` of this action here are run on the
self-hosted runner, the old entries will come back. Keep an eye on it,
possibly you'll have to rinse & repeat.

##### Other code changes in this release

- Update to `actions/checkout@v3` by
[@&#8203;mpdude](https://togithub.com/mpdude) in
[https://github.com/webfactory/ssh-agent/pull/143](https://togithub.com/webfactory/ssh-agent/pull/143)
- Allow the user to override the commands for `git`, `ssh-agent`, and
`ssh-add` by [@&#8203;DilumAluthge](https://togithub.com/DilumAluthge)
in
[https://github.com/webfactory/ssh-agent/pull/154](https://togithub.com/webfactory/ssh-agent/pull/154)

##### New Contributors

- [@&#8203;prhiggins](https://togithub.com/prhiggins) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/153](https://togithub.com/webfactory/ssh-agent/pull/153)
- [@&#8203;kjarkur](https://togithub.com/kjarkur) made their first
contribution in
[https://github.com/webfactory/ssh-agent/pull/147](https://togithub.com/webfactory/ssh-agent/pull/147)
- [@&#8203;DilumAluthge](https://togithub.com/DilumAluthge) made their
first contribution in
[https://github.com/webfactory/ssh-agent/pull/154](https://togithub.com/webfactory/ssh-agent/pull/154)

**Full Changelog**:
webfactory/ssh-agent@v0.7.0...v0.8.0

###
[`v0.7.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v070-2022-10-19)

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.6.0...v0.7.0)

##### Added

- Add the `log-public-key` input that can be used to turn off logging
key identities
([#&#8203;122](https://togithub.com/webfactory/ssh-agent/issues/122))

##### Fixed

- Fix path to `git` binary on Windows, assuming GitHub-hosted runners
([#&#8203;136](https://togithub.com/webfactory/ssh-agent/issues/136),
[#&#8203;137](https://togithub.com/webfactory/ssh-agent/issues/137))
- Fix a nonsensical log message
([#&#8203;139](https://togithub.com/webfactory/ssh-agent/issues/139))

###
[`v0.6.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v060-2022-10-19)

[Compare
Source](https://togithub.com/webfactory/ssh-agent/compare/v0.5.4...v0.6.0)

##### Changed

- Update the version of Node used by the action from 12 to 16
(https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/swc-project/swc).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants