-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-run actions on multi-usage #32
Comments
We could make the cleanup.js ignore errors in case the process to be killed is already gone. Additionally, you might need to kill the first agent before you start the second one. |
@chkpnt Please try to use When you're done with the first agent, |
Thank you for the quick response :-) I've just given your branch a try: And it's working fine: (I'm wondering that some log entries are shown multiple times.... but as the line numbers are the same, that seems to be a GitHub-visualization-issue) |
Ok, I will release that shortly. Any chance you could find out what the underlying issue with Gradle was? Maybe understanding it would help others in the future? |
The Gradle plugin I use is using @ajoberstar's grgit internally which is using jgit which relies on JSch. I tried to reproduced this issue locally by adding both a wrong and a correct key to ssh-agent, but on my Mac, it's working fine. Don't know, why it behaves different within a GitHub workflow :-/ |
First of all, thanks for this GH-Action :-)
I'm using this action twice in my workflow because using a ssh-agent with multiple keys doesn't seem to work with the Gradle-plugin I'm using to push some data to Git-Repositories over ssh.
This works fine, but I have to use
continue-on-error
because otherwise, the second post-run-action (which belongs to the first ssh-agent) fails:Can I somehow trigger the post-run action manually at an earlier step?
Otherwise, I suggest to check in
cleanup.js
, if the process is already killed.ssh-agent/cleanup.js
Line 7 in 8789658
The text was updated successfully, but these errors were encountered: