feat(cc): contact center agent login implementation #3919
+1,746
−507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 14, 2024 15:30
arun3528
requested changes
Oct 15, 2024
| * @returns {Promise<UserResponse>} A promise that eventually resolves to an API response. | ||
| */ | ||
|
|
||
| public async getUserUsingCI(ciUserId: string, orgId: string): Promise<UserResponse> { |
There was a problem hiding this comment.
Please change all the parameter to nested object {}
sreenara
requested changes
Oct 16, 2024
docs/samples/contact-center/app.js
Outdated
| listTeams.forEach((team) => { | ||
| console.log(team); | ||
| if(team.teamType === "AGENT") { | ||
| console.log('inside if condition!'); |
There was a problem hiding this comment.
Please remove unnecessary console.log statements from all files.
packages/@webex/plugin-cc/src/cc.ts
Outdated
| deviceId | ||
| ); | ||
| // eslint-disable-next-line no-console | ||
| console.log('API SUCCESS: agentLoginAPIResponse is', agentLoginResponse); |
Description has been updated with the files to review. This PR is still in Work in Progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #<SPARK-558555>
This pull request addresses
The user should be able to login to agent desktop/station using the below API and get Login response success or failure with reason.
API:- https://developer.webex-cx.com/documentation/agents/v1/login
webex.cc.LoginAgent({teamId, loginOption: 'DialNumber' | 'Extension' | 'Desktop', dialString}) -> Promise
Description:
Login's the agent to agent station by making a POST to the above API
Files that need to be review:
by making the following changes
Change Type
The following scenarios were tested
I have tested my changes through the CC samples app using the UI changes that I have add. I have tested the Post with valid and invalid request.
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.