feat(calling): add rtcMetrics in the call #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarajes2
force-pushed
the
calling-rtcmetrics
branch
from
c167fd7
to
51004e5
Compare
rarajes2
commented
Oct 11, 2024
packages/@webex/internal-plugin-metrics/src/rtcMetrics/index.ts
Outdated
Show resolved
Hide resolved
rarajes2
commented
Oct 11, 2024
rarajes2
commented
Oct 11, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rarajes2
force-pushed
the
calling-rtcmetrics
branch
2 times, most recently
from
51004e5
to
854266f
Compare
sreenara
requested changes
Oct 14, 2024
rarajes2
force-pushed
the
calling-rtcmetrics
branch
from
854266f
to
df7c723
Compare
Kesari3008
reviewed
Oct 16, 2024
Kesari3008
requested changes
Oct 16, 2024
packages/@webex/internal-plugin-metrics/src/rtcMetrics/index.ts
Outdated
Show resolved
Hide resolved
packages/@webex/internal-plugin-metrics/src/rtcMetrics/index.ts
Outdated
Show resolved
Hide resolved
rarajes2
force-pushed
the
calling-rtcmetrics
branch
from
df7c723
to
8642a40
Compare
sreenara
reviewed
Oct 16, 2024
packages/@webex/internal-plugin-metrics/test/unit/spec/rtcMetrics/index.ts
Show resolved
Hide resolved
Kesari3008
approved these changes
Oct 16, 2024
rarajes2
force-pushed
the
calling-rtcmetrics
branch
from
8642a40
to
984eaa3
Compare
sreenara
requested changes
Oct 17, 2024
packages/@webex/internal-plugin-metrics/test/unit/spec/rtcMetrics/index.ts
Show resolved
Hide resolved
rarajes2
force-pushed
the
calling-rtcmetrics
branch
from
984eaa3
to
0275f24
Compare
sreenara
approved these changes
Oct 17, 2024
chrisadubois
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< SPARK-529191 >
This pull request addresses
Adds RtcMetrics to the Calling package.
by making the following changes
Calling SDK is now able to send the RTC Metrics.
Screenshot
Note: Please check the JIRA for HAR file.
Change Type
The following scenarios were tested
Tested both Calling and Meeting stats being sent and attached the HAR files on the JIRA.
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.