Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ca): add saveable sessionCorrelationId #3884

Merged
merged 3 commits into from
Oct 8, 2024
Merged

feat(ca): add saveable sessionCorrelationId #3884

merged 3 commits into from
Oct 8, 2024

Conversation

chrisadubois
Copy link
Collaborator

@chrisadubois chrisadubois commented Oct 4, 2024 •
edited
Loading

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

Saving sessionCorrelationId onto the meeting

by making the following changes

see code

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

automated unit tests

manual
Screenshot 2024-10-04 at 5 06 12 PM
Screenshot 2024-10-04 at 5 05 31 PM

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@chrisadubois chrisadubois requested review from a team as code owners October 4, 2024 23:40
@chrisadubois chrisadubois added the validated If the pull request is validated for automation. label Oct 4, 2024
@aws-amplify-us-east-2 AWS Amplify (us-east-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3884.d3m3l2kee0btzx.amplifyapp.com

chburket
chburket approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@chburket chburket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Coread Coread merged commit 48dcc50 into webex:next Oct 8, 2024
11 checks passed
@chrisadubois chrisadubois mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coread Coread Coread approved these changes

@chburket chburket chburket approved these changes

Assignees
No one assigned
Labels
validated If the pull request is validated for automation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisadubois @Coread @chburket