Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure toBeElementsArrayOfSize doesn't delete passed in array #1706

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

brickfungus
Copy link
Contributor

Fixes #1679

Copy link

linux-foundation-easycla bot commented Nov 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

It seems like the updates to the Eslint dependencies has caused an issue in the pipeline.

@brickfungus
Copy link
Contributor Author

Okay I'll take a look at that. I did try structuredClone at one point

@brickfungus
Copy link
Contributor Author

@christian-bromann why is it testing on node v16 when the package.json file has "engines": { "node": ">=18 || >=20 || >=22" }

@christian-bromann
Copy link
Member

why is it testing on node v16 when the package.json file has "engines": { "node": ">=18 || >=20 || >=22" }

I recognised that the other day, we have to bump the Node.js versions here.

@brickfungus
Copy link
Contributor Author

I changed the workflow file to drop 16 and add 22. Didn't think wdio supported node 16 anymore, anyways, but if you want to do something different, let me know

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 🙏

@christian-bromann christian-bromann merged commit a46f01a into webdriverio:main Nov 8, 2024
6 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Nov 8, 2024

Hey brickfungus 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toBeElementsArrayOfSize seems to alter the array it's check for a moment
3 participants