-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure toBeElementsArrayOfSize doesn't delete passed in array #1706
Make sure toBeElementsArrayOfSize doesn't delete passed in array #1706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It seems like the updates to the Eslint dependencies has caused an issue in the pipeline. |
Okay I'll take a look at that. I did try structuredClone at one point |
@christian-bromann why is it testing on node v16 when the package.json file has |
I recognised that the other day, we have to bump the Node.js versions here. |
I changed the workflow file to drop 16 and add 22. Didn't think wdio supported node 16 anymore, anyways, but if you want to do something different, let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you! 🙏
Hey brickfungus 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Fixes #1679