Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ci): Add manual workflow trigger with Node.js version parameter #109

Merged

Conversation

seanpoulter
Copy link
Contributor

@seanpoulter seanpoulter commented Feb 19, 2024

Proposed Changes

  • Add an on-demand way to run CI pipeline with Node v16

Notes

Not sure if you'd want this in the repo. 🤷 If solves the need to test Node 16 ad hoc without running it all the time.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run the workflow on every commit for one Node version?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Christian Bromann <[email protected]>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit c2b520a into webdriverio-community:main Feb 20, 2024
9 checks passed
@seanpoulter seanpoulter deleted the manual-trigger branch February 20, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants