This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Avoid chromedriver dependency when using chromedriverCustomPath #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
suggested changes
Oct 28, 2021
| @@ -44,7 +44,8 @@ | |||
| "dependencies": { | |||
| "@wdio/logger": "^7.5.3", | |||
| "fs-extra": "^9.1.0", | |||
| "split2": "^3.2.2" | |||
| "split2": "^3.2.2", | |||
| "tcp-port-used": "^1.0.1" | |||
There was a problem hiding this comment.
This is already needed by launcher.js (https://github.com/webdriverio-community/wdio-chromedriver-service/blob/main/src/launcher.js#L7), but is not declared inside package.json, making it unavailable if "chromedriver" is not installed (dependency of this library too)
edit: didn't see your comment
Co-authored-by: Christian Bromann <[email protected]>
This is an improvement of #60 Not a new option, only avoids unnecessary dependency. Thanks for you fast reply! |
christian-bromann
approved these changes
Oct 28, 2021
|
@christian-bromann is this good to go? |
christian-bromann
approved these changes
Jan 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid import of "chromedriver" when using chromedriverCustomPath.
Add "tcp-port-used" as dependency.