-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic package page. #1448
Conversation
A live preview of this PR will be available at the URL below and will update on each commit. = |
static styles = [ | ||
WCOPage.styles, | ||
css` | ||
.full-screen-error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should eventually move this to common styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, done
const {data} = result; | ||
const packageVersion = data.package?.version; | ||
if (packageVersion === undefined) { | ||
throw new Error(`No such package version: ${packageName}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably be rendering a 404 in these cases. TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, TODO added
Fixes #1444