Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic package page. #1448

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Add a basic package page. #1448

merged 2 commits into from
Mar 3, 2023

Conversation

rictic
Copy link
Collaborator

@rictic rictic commented Mar 3, 2023

Fixes #1444

@rictic rictic requested a review from justinfagnani as a code owner March 3, 2023 18:26
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

A live preview of this PR will be available at the URL below and will update on each commit. =
The build takes ~5-10 minutes, and will 404 until finished.

https://pr1448---site-24wnpwhcla-uc.a.run.app/

static styles = [
WCOPage.styles,
css`
.full-screen-error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually move this to common styles

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, done

const {data} = result;
const packageVersion = data.package?.version;
if (packageVersion === undefined) {
throw new Error(`No such package version: ${packageName}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably be rendering a 404 in these cases. TODO?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, TODO added

@rictic rictic enabled auto-merge (squash) March 3, 2023 20:39
@rictic rictic merged commit 5bf9c8c into main Mar 3, 2023
@rictic rictic deleted the package-page branch March 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[catalog] Add a package page
2 participants