Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inherited properties test #2263
base: main
Are you sure you want to change the base?
Add inherited properties test #2263
Changes from 25 commits
a6beb22
9b66359
ad31807
d8cb9d8
8be969b
22be6ae
a28dd5f
e103ad3
16c7eaf
63c8773
d6042f4
3d2f142
cd47c10
65b9177
4cbaa95
a150005
a75ccf3
5bef7e2
b89e837
430fb2f
3fc0c2b
7917e80
9e41e90
f263682
6536e19
f154bf0
e11ab34
b0dd42f
78fe699
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check bools, nums, and strings? Or do you want to do that in a basic test? Follow up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about angularjs but looking at what's already here, i think the component needs to be added here:
custom-elements-everywhere/libraries/angularjs/src/app.module.js
Lines 1 to 21 in c5c71ed
needs to import
ComponentWithInheritance
declared here, and needsand the top of this file also has import lines, which probably needs this added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.... it's working w/o that, but I'm not sure what that means.