Skip to content

Commit

Permalink
chore: clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
ekashida committed Nov 15, 2023
1 parent 14d5157 commit 6b1cee9
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 36 deletions.
32 changes: 16 additions & 16 deletions libraries/lwc/meta/expectedResults.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"success": 24,
"success": 24,
"failed": 8,
"skipped": 0,
"error": false,
"disconnected": false,
"exitCode": 1,
"score": 89,
"basicSupport": {
"total": 16,
"failed": 0,
"passed": 16
},
"advancedSupport": {
"total": 16,
"failed": 8,
"skipped": 0,
"error": false,
"disconnected": false,
"exitCode": 1,
"score": 89,
"basicSupport": {
"total": 16,
"failed": 0,
"passed": 16
},
"advancedSupport": {
"total": 16,
"failed": 8,
"passed": 8
}
"passed": 8
}
}
12 changes: 6 additions & 6 deletions libraries/lwc/meta/issues.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"link": "https://github.com/salesforce/lwc/issues/1904",
"title": "Unnecessary event name restrictions (such as prohibiting hyphens) should be removed",
"meta": "#1904 opened May 28, 2020 by JanMiksovsky"
}
]
{
"link": "https://github.com/salesforce/lwc/issues/1904",
"title": "Unnecessary event name restrictions (such as prohibiting hyphens) should be removed",
"meta": "#1904 opened May 28, 2020 by JanMiksovsky"
}
]
9 changes: 0 additions & 9 deletions libraries/lwc/src/advanced-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ import {

import { expect } from 'chai';

const isCustomElement = (tagName) => {
return window.customElements.get(tagName) !== undefined;
}

// Setup the test harness. This will get cleaned out with every test.
const container = document.createElement('div');
document.body.appendChild(container);
Expand Down Expand Up @@ -87,7 +83,6 @@ describe('advanced support', function() {

cmp.shadowRoot.querySelector('ce-with-event').click();
await Promise.resolve();

expect(handled.textContent).to.eql('true');
});

Expand All @@ -101,7 +96,6 @@ describe('advanced support', function() {

cmp.shadowRoot.querySelector('ce-with-event').click();
await Promise.resolve();

expect(handled.textContent).to.eql('true');
});

Expand All @@ -115,7 +109,6 @@ describe('advanced support', function() {

cmp.shadowRoot.querySelector('ce-with-event').click();
await Promise.resolve();

expect(handled.textContent).to.eql('true');
});

Expand All @@ -129,7 +122,6 @@ describe('advanced support', function() {

cmp.shadowRoot.querySelector('ce-with-event').click();
await Promise.resolve();

expect(handled.textContent).to.eql('true');
});

Expand All @@ -143,7 +135,6 @@ describe('advanced support', function() {

cmp.shadowRoot.querySelector('ce-with-event').click();
await Promise.resolve();

expect(handled.textContent).to.eql('true');
});
});
Expand Down
4 changes: 2 additions & 2 deletions libraries/lwc/src/basic-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ describe('basic support', function() {
const elm = cmp.shadowRoot.querySelector('#dummy');
expect(elm).to.exist;
expect(elm.textContent).to.eql('Dummy view');

toggler.click();
await Promise.resolve();

expectHasChildren(cmp.shadowRoot.querySelector('ce-with-children'));
});
});
Expand Down Expand Up @@ -182,9 +182,9 @@ describe('basic support', function() {

const handled = cmp.shadowRoot.querySelector('.handled');
expect(handled.textContent).to.eql('false');

cmp.shadowRoot.querySelector('ce-with-event').click();
await Promise.resolve();

expect(handled.textContent).to.eql('true');
});
});
Expand Down
2 changes: 1 addition & 1 deletion libraries/lwc/src/modules/x/withChildren/withChildren.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<template>
<ce-with-children id="wc" lwc:external></ce-with-children>
<ce-with-children lwc:external></ce-with-children>
</template>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<ce-with-properties id="wc" lwc:external
<ce-with-properties lwc:external
bool={bool}
num={num}
str={str}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<template>
<ce-without-children id="wc" lwc:external></ce-without-children>
<ce-without-children lwc:external></ce-without-children>
</template>

0 comments on commit 6b1cee9

Please sign in to comment.