[context] Rename multiple to subscribe
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @benjamind |
Westbrook
changed the title
multiple to unsubscribemultiple to subscribe
Westbrook
reviewed
Feb 3, 2023
|
Yes looks good to me, thanks for pulling this up from the |
Co-authored-by: Westbrook Johnson <[email protected]>
|
Thanks y'all. I'm going to go with the written LGTM here and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24 and #21
Clarifies the language around when a provider should keep a reference to a request callback. Some minor related example cleanup too.