Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set and remove method signatures #81

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

vtintillier
Copy link
Contributor

@vtintillier vtintillier commented Jan 11, 2024

Fixes #80.

@ashleyfrieze
Copy link
Member

Nice. Looks like good code and some useful tests to secure down the structure you want.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cb1edd) 80.16% compared to head (a6ffe35) 80.14%.

❗ Current head a6ffe35 differs from pull request most recent head 1cc987d. Consider uploading reports for the commit 1cc987d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #81      +/-   ##
============================================
- Coverage     80.16%   80.14%   -0.03%     
+ Complexity      344      343       -1     
============================================
  Files            49       49              
  Lines           837      836       -1     
  Branches         44       44              
============================================
- Hits            671      670       -1     
  Misses          149      149              
  Partials         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vtintillier vtintillier marked this pull request as ready for review January 11, 2024 22:32
@ashleyfrieze ashleyfrieze merged commit 987b72c into webcompere:main Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.3.5 breaks backward compatibility
3 participants