Support removal of environment variables and system properties #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtintillier
reviewed
Jan 11, 2024
Comment on lines
+394
to
+396
| SystemProperties someProperties = new SystemProperties() | ||
| .remove("property1") | ||
| .remove("property2"); |
There was a problem hiding this comment.
this does not compile due to the introduction of SystemPropertiesImpl.
Also this PR breaks backward compatibility. This was working before but no longer does:
class SomeTest {
@SystemStub
private static SystemProperties systemProperties = new MySystemProperties().set("property", "value");
}
class MySystemProperties extends SystemProperties {
public MySystemProperties() {
super("key1", "value1");
this.set("key2", "value2");
}
}Created #80 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #71 - this allows
removeto be called onEnvironmentVariablesandSystemPropertiesto request that any existing property/variable is completely removed from the map when stubbing is active. This is better than usingset()