Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readmemd #115

Closed
wants to merge 4 commits into from
Closed

Readmemd #115

wants to merge 4 commits into from

Conversation

architajain12
Copy link
Contributor

Issue #87 amended.
Updated screenshots in readme.md and removed the screenshot for safari.

@architajain12
Copy link
Contributor Author

r? @miketaylr

@miketaylr
Copy link
Member

@architajain12 thanks!

2 things please:

  1. edit the title of the PR so it says something like "Fixes Update screenshots in README.md #87. Updated screenshots in README.md"
  2. for the firefox for android screenshot, i think we still need to show what it looks like in the menu, e.g.,

screenshot_20180322-105447

can you update that? thanks.

miketaylr
miketaylr requested changes Mar 22, 2018
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(can you also rebase your PR against the latest master branch? that way the commits for the chrome run stuff won't appear in this PR)

@miketaylr
Copy link
Member

I'm gonna close this as inactive, but please comment if you'd like to push it over the line and we can re-open! 💯

@miketaylr miketaylr closed this May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr requested changes

Assignees
No one assigned
Labels
inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@architajain12 @miketaylr