Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #85 - Add triage dashboard #148

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Fixes #85 - Add triage dashboard #148

merged 4 commits into from
Mar 29, 2019

Conversation

laghee
Copy link
Contributor

@laghee laghee commented Mar 20, 2019

Let me know if I did this correctly, @magsout. The endpoint doesn't exist yet because I need to get that done server-side, so maybe that's why I can't see a new dashboard tab when I run it locally?

Maybe I should have waited until I had all the endpoints lined up, but I wanted to be sure I knew how to use the new super-simple container correctly in the meantime... 😍

@laghee laghee requested a review from magsout March 20, 2019 18:10
@karlcow karlcow temporarily deployed to webcompat-dashboard-pr-148 March 20, 2019 18:10 Inactive
@magsout
Copy link
Member

magsout commented Mar 20, 2019

@laghee to see the item in the menu, you have to add the link under https://github.com/webcompat/webcompat-metrics-client/blob/master/src/layouts/index.js#L19

@magsout
Copy link
Member

magsout commented Mar 20, 2019

Maybe I should have waited until I had all the endpoints lined up, but I wanted to be sure I knew how to use the new super-simple container correctly in the meantime... 😍

ah ah ah thanks <3

@laghee
Copy link
Contributor Author

laghee commented Mar 20, 2019

@laghee to see the item in the menu, you have to add the link under https://github.com/webcompat/webcompat-metrics-client/blob/master/src/layouts/index.js#L19

Aha!

...OK, I tried importing the container and adding the link:
Screenshot 2019-03-21 00 14 06

But I'm still not seeing anything in the menu:
Screenshot 2019-03-21 00 14 47

Ah, wait! Looks like I needed to add a link here, too:

Yep, OK, now we're in business:
Screenshot 2019-03-21 00 34 46

Thanks, @magsout! I'll get this set up on the server and update the test data, and then, I think?, we should be good to go.

P.S. -- I took the liberty of capitalizing "Diagnosis" in the menu bar, because with all the starts-with-"Needs" tabs, I thought it would help distinguish from "Triage" (and the future "Contact").

@karlcow karlcow temporarily deployed to webcompat-dashboard-pr-148 March 20, 2019 23:38 Inactive
@karlcow karlcow temporarily deployed to webcompat-dashboard-pr-148 March 20, 2019 23:41 Inactive
@magsout
Copy link
Member

magsout commented Mar 21, 2019

If I may, the only thing missing is a small test for NeedsTriage 😘

@laghee
Copy link
Contributor Author

laghee commented Mar 21, 2019

@magsout, I added a test, but I'm getting weird eslint errors locally when I run all the tests (maybe related to this? -- AtomLinter/linter-eslint#1100):
Screenshot 2019-03-21 16 42 13

All the CI tests passed, so... maybe just my machine being quirky with eslint?

@magsout
Copy link
Member

magsout commented Mar 21, 2019

All the CI tests passed, so... maybe just my machine being quirky with eslint?

yes, if CI passed, it's ok. let me also test locally.

@magsout
Copy link
Member

magsout commented Mar 21, 2019

@laghee

Capture d’écran 2019-03-21 à 18 11 01

everything is good 👍

@laghee
Copy link
Contributor Author

laghee commented Mar 28, 2019

OK, server side PR is waiting on review from @karlcow (webcompat/webcompat-metrics-server#99). Let me know if you think we're good to go after that, @magsout!

@magsout
Copy link
Member

magsout commented Mar 29, 2019

@laghee parameters from and to doesn't do anything ? the API responses are the same whatever filters I choose.

@laghee
Copy link
Contributor Author

laghee commented Mar 29, 2019

@magsout The problem is that my script has only been collecting data since yesterday evening... so there are limited data points. I think our defaults are set up to use whatever data is available in that case. The same thing happens if you choose a range with a starting date before Feb. 2018 for NeedsDiagnosis.

I'm planning on adding some back-dated counts, but still working out the best way to do that.

@magsout
Copy link
Member

magsout commented Mar 29, 2019

@laghee oh ok. thanks for the explanation.

Copy link
Member

@magsout magsout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laghee super nice work. LGTM. feel free to merge when you want.

@magsout
Copy link
Member

magsout commented Mar 29, 2019

@laghee maybe, i can think how I can add a min-date on the from input? What do you think? (let open a new issue if needed)

@laghee laghee merged commit 45875a3 into master Mar 29, 2019
@laghee laghee deleted the issues/85 branch March 29, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants