-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #85 - Add triage dashboard #148
Conversation
@laghee to see the item in the menu, you have to add the link under https://github.com/webcompat/webcompat-metrics-client/blob/master/src/layouts/index.js#L19 |
ah ah ah thanks <3 |
Aha! ...OK, I tried importing the container and adding the link: But I'm still not seeing anything in the menu: Ah, wait! Looks like I needed to add a link here, too:
Yep, OK, now we're in business: Thanks, @magsout! I'll get this set up on the server and update the test data, and then, I think?, we should be good to go. P.S. -- I took the liberty of capitalizing "Diagnosis" in the menu bar, because with all the starts-with-"Needs" tabs, I thought it would help distinguish from "Triage" (and the future "Contact"). |
If I may, the only thing missing is a small test for NeedsTriage 😘 |
@magsout, I added a test, but I'm getting weird All the CI tests passed, so... maybe just my machine being quirky with |
yes, if CI passed, it's ok. let me also test locally. |
everything is good 👍 |
OK, server side PR is waiting on review from @karlcow (webcompat/webcompat-metrics-server#99). Let me know if you think we're good to go after that, @magsout! |
@laghee parameters |
@magsout The problem is that my script has only been collecting data since yesterday evening... so there are limited data points. I think our defaults are set up to use whatever data is available in that case. The same thing happens if you choose a range with a starting date before Feb. 2018 for NeedsDiagnosis. I'm planning on adding some back-dated counts, but still working out the best way to do that. |
@laghee oh ok. thanks for the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laghee super nice work. LGTM. feel free to merge when you want.
@laghee maybe, i can think how I can add a min-date on the from input? What do you think? (let open a new issue if needed) |
Let me know if I did this correctly, @magsout. The endpoint doesn't exist yet because I need to get that done server-side, so maybe that's why I can't see a new dashboard tab when I run it locally?
Maybe I should have waited until I had all the endpoints lined up, but I wanted to be sure I knew how to use the new super-simple container correctly in the meantime... 😍