Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with checkZFT static method #406

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Fix for issue with checkZFT static method #406

merged 4 commits into from
Nov 22, 2024

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Nov 22, 2024

This pull request includes several changes aimed at improving code quality and updating dependencies. The most important changes involve refactoring variable declarations, removing unnecessary console logs, updating the TypeScript version, and modifying a utility function.

Code Quality Improvements:

  • Refactored variable declarations from var to let and const in js/artoolkitNFT.embed_ES6_worker.js and js/artoolkitNFT.multi_worker.js to improve scope handling and code readability. [1] [2]
  • Removed unnecessary console.log statements in js/artoolkitNFT.embed_ES6_worker.js and js/artoolkitNFT_ES6.worker.js to clean up the console output. [1] [2]

Dependency Updates:

  • Updated the TypeScript version in package.json from 5.5.4 to 5.6.3 to ensure compatibility with the latest features and bug fixes.

Utility Function Modification:

  • Updated the checkZFT function in src/Utils.ts to use synchronous XMLHttpRequest instead of axios, simplifying the function and ensuring correct return types.

Configuration Changes:

  • Removed the Node.js language specification from .travis.yml as it is no longer needed.This pull request includes a significant change to the checkZFT method in the Utils class within the src/Utils.ts file. The method has been refactored to simplify its implementation and improve its reliability, and to solve an issue while loading not .zft files

Key changes:

  • Simplified the checkZFT method to use a synchronous XMLHttpRequest instead of an asynchronous axios request. This change ensures that the method returns a boolean value directly based on the HTTP response status.

@kalwalt kalwalt added bug Something isn't working enhancement New feature or request Typescript labels Nov 22, 2024
@kalwalt kalwalt self-assigned this Nov 22, 2024
@kalwalt kalwalt changed the title fix for issue with checkZFT static method Fix for issue with checkZFT static method Nov 22, 2024
@kalwalt kalwalt merged commit c056ea9 into dev Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant