Fix for issue with checkZFT static method #406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving code quality and updating dependencies. The most important changes involve refactoring variable declarations, removing unnecessary console logs, updating the TypeScript version, and modifying a utility function.
Code Quality Improvements:
var
tolet
andconst
injs/artoolkitNFT.embed_ES6_worker.js
andjs/artoolkitNFT.multi_worker.js
to improve scope handling and code readability. [1] [2]console.log
statements injs/artoolkitNFT.embed_ES6_worker.js
andjs/artoolkitNFT_ES6.worker.js
to clean up the console output. [1] [2]Dependency Updates:
package.json
from 5.5.4 to 5.6.3 to ensure compatibility with the latest features and bug fixes.Utility Function Modification:
checkZFT
function insrc/Utils.ts
to use synchronousXMLHttpRequest
instead ofaxios
, simplifying the function and ensuring correct return types.Configuration Changes:
.travis.yml
as it is no longer needed.This pull request includes a significant change to thecheckZFT
method in theUtils
class within thesrc/Utils.ts
file. The method has been refactored to simplify its implementation and improve its reliability, and to solve an issue while loading not .zft filesKey changes:
checkZFT
method to use a synchronousXMLHttpRequest
instead of an asynchronousaxios
request. This change ensures that the method returns a boolean value directly based on the HTTP response status.