Feature improves transmatrix #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- npm packages upgrade
- bunch of debug logs - removing enableBlur bool variable because not necessary anymore (commit files previously missed)
kalwalt
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the WebARKit codebase, focusing on adding support for different types of blur and improving logging and tracking functionality. The most important changes include the introduction of a
BLUR_TYPEenum, modifications to theprocessFrameDatamethod to support different blur types, and updates to the tracking information handling.Blur type support:
BLUR_TYPEenum to specify different types of blur:MEDIAN_BLUR,BOX_BLUR, andNONE_BLUR. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/include/WebARKitTrackers/WebARKitOpticalTracking/WebARKitEnums.h)processFrameDatamethod signatures and implementations to acceptBLUR_TYPEinstead of a boolean for enabling blur. (WebARKit/WebARKitManager.cpp,WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp,WebARKit/WebARKitTrackers/WebARKitOpticalTracking/include/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.h,WebARKit/include/WebARKitManager.h) [1] [2] [3] [4] [5] [6]Logging improvements:
WebARKitTrackerImplclass. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp) [1] [2]convert2Grayscalefunction. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/include/WebARKitTrackers/WebARKitOpticalTracking/WebARKitUtils.h)Tracking information updates:
updateTrackablemethod to theWebARKitPatternTrackingInfoclass to update transformation matrices. (WebARKit/WebARKitPattern.cpp,WebARKit/include/WebARKitPattern.h) [1] [2]getPoseMatrix2method to return the updated transformation matrix. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp)updateTrackablemethod during the tracking process to ensure the transformation matrix is updated. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp)