webruntime: upgrade to submissions/28 and drop upstreamed patches #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shr-project
commented
May 17, 2023
shr-project
commented
- on gentoo with gcc-13 on host there is one more issue with dev-cpp/abseil-cpp-20230125.2 while older dev-cpp/abseil-cpp-20220623.1 works fine when building host's flatbuffers, similar to: Which abseil is current protobuf compatible with? protocolbuffers/protobuf#10768
* on gentoo with gcc-13 on host there is one more issue with dev-cpp/abseil-cpp-20230125.2 while older dev-cpp/abseil-cpp-20220623.1 works fine when building host's flatbuffers, similar to: protocolbuffers/protobuf#10768 Signed-off-by: Martin Jansa <[email protected]>
Tofee
approved these changes
May 18, 2023
|
I haven't checked on any target, just build tested with Nanbield and still looking at that abseil issue from host. |
|
Ok, I'll check on pinephone and qemu-x64 |
* on gentoo with gcc-13 on host there is one more issue with dev-cpp/abseil-cpp-20230125.2 while older dev-cpp/abseil-cpp-20220623.1 works fine when building host's flatbuffers, similar to: protocolbuffers/protobuf#10768 webruntime $ grep include/absl 94-r59.2/temp/log.do_compile.* | sort -u 94-r59.2/temp/log.do_compile.2082512:/usr/include/absl/strings/string_view.h:52:21: note: ‘std::string_view’ is only available from C++17 onwards 94-r59.2/temp/log.do_compile.2082512:/usr/include/absl/strings/string_view.h:52:26: error: ‘string_view’ in namespace ‘std’ does not name a type 94-r59.2/temp/log.do_compile.2082512:/usr/include/absl/strings/string_view.h:686:8: error: ‘string_view’ does not name a type 94-r59.2/temp/log.do_compile.2082512:/usr/include/absl/strings/string_view.h:697:11: error: ‘string_view’ does not name a type * it still builds own version of host absl with or without abseil-cpp-native dependency: 94-r59.2/temp/log.do_compile.1947113:[11550/43007] STAMP host/obj/third_party/abseil-cpp/absl.stamp 94-r59.2/temp/log.do_compile.2082512:[11326/43007] STAMP host/obj/third_party/abseil-cpp/absl.stamp but at least now it works even with newer absl on host Signed-off-by: Martin Jansa <[email protected]>
|
I now tested qemux86-64, and I saw no regression |
I also validate the PR on pinephone. For me it's good to go. @Herrie82 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.