fix: encoding ints/uints #854
Draft
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
commented
Apr 7, 2024
| // This one shouldn't have data offset | ||
| hexData = ABIEncoder.encode(types: [.array(type: .uint(bits: 8), length: 4)], values: [[1, 2, 3, 4]])?.toHexString() | ||
| // First 32 bytes are the first value from the array | ||
| XCTAssertEqual(hexData?[0..<64], "0000000000000000000000000000000000000000000000000000000000000001") | ||
| XCTAssertEqual(hexData, "0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000030000000000000000000000000000000000000000000000000000000000000004") | ||
| // XCTAssertEqual(hexData?[0..<32], "0000000000000000000000000000000000000000000000000000000000000001") |
There was a problem hiding this comment.
Wasn't sure about this line. @JeneaVranceanu @yaroslavyaroslav
Is it actually needed or could it be deleted? Because of the bug fix of uint bits this hex string is now signficantly shorter.
yaroslavyaroslav
force-pushed
the
develop
branch
4 times, most recently
from
a0218ff to
8c152f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
intanduintwhich was not taking thebitsparameter into accountTest Data or Screenshots
ABIEncoderTestBy submitting this pull request, you are confirming the following:
developbranch.