Add Support For The Mnemonic Phrase To Be An Array #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeneaVranceanu
requested changes
Mar 6, 2023
janndriessen
reviewed
Mar 8, 2023
janndriessen
reviewed
Mar 8, 2023
janndriessen
reviewed
Mar 8, 2023
JeneaVranceanu
requested changes
Mar 9, 2023
Instead of calling `try? getPrefixNodeData(password)` in a function that is able to throw we must call `try getPrefixNodeData(password)`.
JeneaVranceanu
requested changes
Mar 9, 2023
updated, thank you |
pharms-eth
requested review from
JeneaVranceanu,
yaroslavyaroslav and
janndriessen
how do things look? |
JeneaVranceanu
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
@pharms-eth Thanks for the effort!
Sorry, it took more time than expected.
Now this PR LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update Mnemonic creation to support arrays
Test Data or Screenshots
added 3 new tests which pass