Mnemonic data #791
Merged
Mnemonic data #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pharms-eth Is this PR aimed to fix the same issue as #790 ? Changes seem to be at least partially identical. |
no, these are fixing seed phrase issues |
JeneaVranceanu
requested changes
Apr 2, 2023
JeneaVranceanu
requested changes
Apr 2, 2023
JeneaVranceanu
requested changes
Aug 29, 2023
JeneaVranceanu
requested changes
Aug 29, 2023
Sources/Web3Core/EthereumNetwork/Request/APIRequest+Methods.swift
Outdated
Show resolved
Hide resolved
This reverts commit e8a5e2b.
yaroslavyaroslav
approved these changes
Aug 31, 2023
JeneaVranceanu
approved these changes
Nov 7, 2023
JeneaVranceanu
added a commit
to JeneaVranceanu/web3swift
that referenced
this pull request
Jan 16, 2024
* develop: (24 commits) refactor: random bytes generation; data and string extensions update (web3swift-team#791) encodeTopic bytes should accept hex string add more test for encodeTopic Trim Trailing Whitespace remove a force unwrap feat: enable encode Event and IETH.getLogs - isHardened check removed from createNewCustomChildAccount - linter warning fixed chore: trailing closure style for compactMap fix: used short notation for null checking fix: trimming / only if it's present as a prefix; using let for 'newPath'; - Test testAddressGeneration modified with hardcoded addresses chore: refactoring of createNewCustomChildAccount - bug with original pathAppendix fixed fix: createNewAccount always non-hardened derivation - Trailing Whitespace fixed in tests - not used code removed - small refactoring - closure style updated - pathAppendix declaration place changed - linter Trailing Whitespace Violation fixed - Grammar fixed - Removed prefix path from address generation ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
half of the Mnemonic changes that have been coming
this one cleans up some of the data calculations