-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for WebSocket #714
base: develop-4.0
Are you sure you want to change the base?
feat: adding support for WebSocket #714
Conversation
It could be missed in the rush, so I just refresh it: why do we consider adding websocket as 4.0 feature rather then minor update for the 3.* one @JeneaVranceanu? |
@yaroslavyaroslav I think we will have to change the way we store and manage |
@JeneaVranceanu I'm really curious why the WebSocket will lead to changes that you've mentioned. Looking forward to hear from you, no rushing tho. |
WARNING: It's a WIP. If you wish to you can review the PR but it's not finished yet.
Summary of Changes
Adds support for WebSockets that will be part of 4.0 release.
DefaultWeb3SocketClient
was added and is based on the nativeURLSessionWebSocketTask
. It's wrapped in#if !os(Linux) ... #endif
so we can add a separate instance ofDefaultWeb3SocketClient
for Linux based on some other library that supports Linux.Issues that are left to resolve/add:
attachedKeystore
to theweb3
class;Test Data or Screenshots
empty
By submitting this pull request, you are confirming the following:
develop
branch.