Fix tokenURI method name for ERC721 and ERC721x tokens #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloit
approved these changes
Mar 15, 2022
pharms-eth
approved these changes
Mar 16, 2022
pharms-eth
approved these changes
Mar 16, 2022
yaroslavyaroslav
approved these changes
Mar 21, 2022
|
This PR does pass on my system, and from the changes I see no reason why it should fail here. Maybe an issue with the automated test? As as far as I can tell there are no tests for these ERC's. I have manually verified that the names in the PR are correct. |
1 similar comment
|
This PR does pass on my system, and from the changes I see no reason why it should fail here. Maybe an issue with the automated test? As as far as I can tell there are no tests for these ERC's. I have manually verified that the names in the PR are correct. |
|
@yaroslavyaroslav Please, re-run CI for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change method name used in
tokenURI(tokenId:)from "tokenId" to "tokenURI" for bothERC721andERC721xtokens.Fixes #419