-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethers Migration guide #7441
Ethers Migration guide #7441
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7441 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 218 218
Lines 8637 8637
Branches 2364 2364
=======================================
Hits 8166 8166
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
Could you please also add a viem migration page with just "Coming soon"? |
``` | ||
npm install ethers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also specify the ethers version here.
|
||
```typescript | ||
const contract = new ethers.Contract(CONTRACT_ADDRESS, ABI, providerOrSigner); | ||
const result = await contract.someFunction(); | ||
const signer = provider.getSigner(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const signer = provider.getSigner(); | |
const signer = await provider.getSigner(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Description
Ethers Migration guide
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.