-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Contract methods input param type any[] #7340
Fix Contract methods input param type any[] #7340
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 2122260 | Previous: ed85cce | Ratio |
---|---|---|---|
processingTx |
21649 ops/sec (±7.60% ) |
22475 ops/sec (±7.29% ) |
1.04 |
processingContractDeploy |
38587 ops/sec (±7.85% ) |
37859 ops/sec (±7.67% ) |
0.98 |
processingContractMethodSend |
15284 ops/sec (±7.27% ) |
16019 ops/sec (±6.80% ) |
1.05 |
processingContractMethodCall |
27268 ops/sec (±6.34% ) |
27428 ops/sec (±6.22% ) |
1.01 |
abiEncode |
42172 ops/sec (±7.05% ) |
42843 ops/sec (±7.53% ) |
1.02 |
abiDecode |
29787 ops/sec (±8.57% ) |
29934 ops/sec (±7.71% ) |
1.00 |
sign |
1529 ops/sec (±0.57% ) |
1501 ops/sec (±3.06% ) |
0.98 |
verify |
358 ops/sec (±2.92% ) |
368 ops/sec (±0.51% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plus check failing tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7340 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 217 217
Lines 8483 8483
Branches 2343 2343
=======================================
Hits 8013 8013
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All sounds great!
Just a tiny suggestion.
* fix types * fix * Update type.test.ts * fix tests * fix test
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #7302
Behavior right now
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.