fix: ensure contractInstance.subscriptionManager.subscribe is not throwing

[Muhammad-Altabba]

Description

Fixes #6288

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run lint with success and extended the tests and types if necessary.
• I ran npm run test:unit with success.
• I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
• I ran npm run build and tested dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• I have updated the CHANGELOG.md file in the root folder.
• I have linked Issue(s) with this PR in "Linked Issues" menu.

[github-actions]

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	641.08 kB → 642.15 kB (+1.06 kB)	+0.17%

Changeset

File	Δ	Size
../web3-eth-contract/lib/commonjs/contract_log_subscription.js	🆕 +3.89 kB	0 B → 3.89 kB
../web3-eth-contract/lib/commonjs/contract-subscription-manager.js	🆕 +3.16 kB	0 B → 3.16 kB
../web3-eth-contract/lib/commonjs/contract.js	📈 +403 B (+0.94%)	41.75 kB → 42.15 kB
../web3-eth-contract/lib/commonjs/index.js	📈 +9 B (+0.34%)	2.61 kB → 2.62 kB
../web3-eth-contract/lib/commonjs/log_subscription.js	🔥 -3.6 kB (-100%)	3.6 kB → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
web3.min.js	621.56 kB → 622.62 kB (+1.06 kB)	+0.17%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
../lib/commonjs/index.d.ts	8.72 kB	0%
../lib/commonjs/accounts.d.ts	3.89 kB	0%
../lib/commonjs/types.d.ts	2.67 kB	0%
../lib/commonjs/web3.d.ts	1.38 kB	0%
../lib/commonjs/web3_eip6963.d.ts	1.28 kB	0%
../lib/commonjs/abi.d.ts	1.06 kB	0%
../lib/commonjs/eth.exports.d.ts	280 B	0%
../lib/commonjs/providers.exports.d.ts	183 B	0%
../lib/commonjs/version.d.ts	60 B	0%

[github-actions]

Benchmark

Benchmark suite	Current: aefb2f8	Previous: fab66e9	Ratio
processingTx	22361 ops/sec (±6.60%)	22533 ops/sec (±6.62%)	1.01
processingContractDeploy	40421 ops/sec (±7.38%)	39420 ops/sec (±7.63%)	0.98
processingContractMethodSend	16498 ops/sec (±8.97%)	16012 ops/sec (±7.57%)	0.97
processingContractMethodCall	28896 ops/sec (±6.61%)	27328 ops/sec (±7.22%)	0.95
abiEncode	45680 ops/sec (±6.97%)	42745 ops/sec (±7.84%)	0.94
abiDecode	30541 ops/sec (±8.91%)	29680 ops/sec (±8.64%)	0.97
sign	1552 ops/sec (±3.60%)	1484 ops/sec (±3.35%)	0.96
verify	372 ops/sec (±0.63%)	364 ops/sec (±0.49%)	0.98

This comment was automatically generated by workflow using github-action-benchmark.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (fab66e9) to head (aefb2f8).
Report is 1 commits behind head on 4.x.

Additional details and impacted files

@@           Coverage Diff           @@
##              4.x    #7327   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         216      217    +1     
  Lines        8470     8483   +13     
  Branches     2341     2343    +2     
=======================================
+ Hits         8000     8013   +13     
  Misses        470      470           

Flag	Coverage Δ
UnitTests	94.45% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.