-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make getEthereumjsTxDataFromTransaction not trim extra fields #7282
feat: make getEthereumjsTxDataFromTransaction not trim extra fields #7282
Conversation
I also took the opportunity to modify |
f87e165
to
f176bff
Compare
b977445
to
3371c43
Compare
@nicolasbrugneaux could you pls test dev release https://www.npmjs.com/package/web3/v/4.13.1-dev.cc99825.0?activeTab=versions in your app. |
Hello! I was OOO for a couple of days. I'll get right on testing that. |
Description
This PR refactors
getEthereumjsTxDataFromTransaction
to not trim extra fields anymore whilst still aliasinginput
andgasLimit
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.[ Closes #7273 ]