Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make getEthereumjsTxDataFromTransaction not trim extra fields #7282

Merged

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Sep 23, 2024

Description

This PR refactors getEthereumjsTxDataFromTransaction to not trim extra fields anymore whilst still aliasing input and gasLimit

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

[ Closes #7273 ]

@nicolasbrugneaux
Copy link
Contributor Author

I also took the opportunity to modify SomeNewTxTypeTransaction class to have a custom field so we can kinda e2e tests plugins using custom fields through customTransactionSchema

@nicolasbrugneaux nicolasbrugneaux force-pushed the nicolasbrugneaux/getEthereumjsTxDataFromTransaction branch from f87e165 to f176bff Compare September 24, 2024 14:39
@nicolasbrugneaux nicolasbrugneaux force-pushed the nicolasbrugneaux/getEthereumjsTxDataFromTransaction branch from b977445 to 3371c43 Compare September 24, 2024 14:42
@jdevcs jdevcs merged commit cc99825 into web3:4.x Sep 26, 2024
16 of 18 checks passed
@jdevcs
Copy link
Contributor

jdevcs commented Sep 26, 2024

@nicolasbrugneaux
Copy link
Contributor Author

@nicolasbrugneaux could you pls test dev release https://www.npmjs.com/package/web3/v/4.13.1-dev.cc99825.0?activeTab=versions in your app.

Hello! I was OOO for a couple of days. I'll get right on testing that.

@nicolasbrugneaux
Copy link
Contributor Author

Had to adjust a little bit my dependencies, but it worked wonders, I suppose once they're all released as latest it won't be necessary to play with resolutions anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin] customTransactionSchema follow-up
3 participants