feat/docs/plugin-middleware #7158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danforbes
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: eb29499 | Previous: 5f6deeb | Ratio |
|---|---|---|---|
processingTx |
8887 ops/sec (±4.94%) |
9233 ops/sec (±3.97%) |
1.04 |
processingContractDeploy |
39097 ops/sec (±7.05%) |
40168 ops/sec (±4.88%) |
1.03 |
processingContractMethodSend |
16534 ops/sec (±7.46%) |
16302 ops/sec (±6.45%) |
0.99 |
processingContractMethodCall |
28387 ops/sec (±6.22%) |
28306 ops/sec (±6.19%) |
1.00 |
abiEncode |
43396 ops/sec (±6.78%) |
42794 ops/sec (±8.67%) |
0.99 |
abiDecode |
30773 ops/sec (±5.83%) |
31117 ops/sec (±7.21%) |
1.01 |
sign |
1525 ops/sec (±3.92%) |
1588 ops/sec (±0.64%) |
1.04 |
verify |
366 ops/sec (±0.47%) |
367 ops/sec (±0.70%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7158 +/- ##
=======================================
Coverage 94.45% 94.46%
=======================================
Files 215 215
Lines 8391 8396 +5
Branches 2313 2315 +2
=======================================
+ Hits 7926 7931 +5
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
jdevcs
reviewed
Jul 22, 2024
|
|
||
| ### Request Middleware | ||
|
|
||
| Request middleware allows plugins to modify RPC requests before they are sent to the network and modify RPC responses before they are returned to the user. Request middleware must implement the [`RequestManagerMiddleware`](/api/web3-core/interface/RequestManagerMiddleware) interface, which specifies two functions: [`processRequest`](/api/web3-core/interface/RequestManagerMiddleware#processRequest) and [`processResponse`](/api/web3-core/interface/RequestManagerMiddleware#processResponse). Here is a simple example of request middleware that prints RPC requests and responses to the console: |
There was a problem hiding this comment.
Suggested change
| Request middleware allows plugins to modify RPC requests before they are sent to the network and modify RPC responses before they are returned to the user. Request middleware must implement the [`RequestManagerMiddleware`](/api/web3-core/interface/RequestManagerMiddleware) interface, which specifies two functions: [`processRequest`](/api/web3-core/interface/RequestManagerMiddleware#processRequest) and [`processResponse`](/api/web3-core/interface/RequestManagerMiddleware#processResponse). Here is a simple example of request middleware that prints RPC requests and responses to the console: | |
| Request middleware allows plugins to modify RPC requests before they are sent to the network and modify RPC responses before they are returned to the web3.js lib's other packages for internal processing. Request middleware must implement the [`RequestManagerMiddleware`](/api/web3-core/interface/RequestManagerMiddleware) interface, which specifies two functions: [`processRequest`](/api/web3-core/interface/RequestManagerMiddleware#processRequest) and [`processResponse`](/api/web3-core/interface/RequestManagerMiddleware#processResponse). Here is a simple example of request middleware that prints RPC requests and responses to the console: |
jdevcs
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
@danforbes looks good, thanks.
I suggested a change before merging.
avkos
approved these changes
Jul 22, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plugin middleware documentation
Closes #6963