100% Coverage web3-utills #7042
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: b9617ee | Previous: 51d216f | Ratio |
|---|---|---|---|
processingTx |
9064 ops/sec (±3.95%) |
9224 ops/sec (±3.84%) |
1.02 |
processingContractDeploy |
39316 ops/sec (±6.24%) |
41118 ops/sec (±7.75%) |
1.05 |
processingContractMethodSend |
18824 ops/sec (±7.24%) |
20556 ops/sec (±6.13%) |
1.09 |
processingContractMethodCall |
37602 ops/sec (±6.05%) |
41085 ops/sec (±4.96%) |
1.09 |
abiEncode |
42235 ops/sec (±7.66%) |
46586 ops/sec (±6.55%) |
1.10 |
abiDecode |
28950 ops/sec (±8.61%) |
31710 ops/sec (±6.85%) |
1.10 |
sign |
1578 ops/sec (±0.79%) |
1608 ops/sec (±0.76%) |
1.02 |
verify |
369 ops/sec (±0.64%) |
374 ops/sec (±2.89%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7042 +/- ##
==========================================
+ Coverage 92.17% 93.98% +1.81%
==========================================
Files 215 215
Lines 8335 8335
Branches 2301 2301
==========================================
+ Hits 7683 7834 +151
+ Misses 652 501 -151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -74,11 +72,7 @@ const findSchemaByDataPath = ( | |||
| result = (result.properties as Record<string, JsonSchema>)[dataPart]; | |||
| } else if (result.items && (result.items as JsonSchema).properties) { | |||
| const node = (result.items as JsonSchema).properties as Record<string, JsonSchema>; | |||
|
|
|||
| if (!node) { | |||
There was a problem hiding this comment.
we remove this
this conditional can never be met,
} else if (result.items && (result.items as JsonSchema).properties) {
we make sure result.properties always exists
| @@ -57,10 +57,8 @@ const findSchemaByDataPath = ( | |||
|
|
|||
| for (const dataPart of dataPath) { | |||
| if (result.oneOf && previousDataPath) { | |||
| const path = oneOfPath.find(function (element: [string, number]) { | |||
There was a problem hiding this comment.
changed this for readability
| clearInterval(intervalId); | ||
| resolve(res as unknown as Exclude<T, undefined>); | ||
| reject(error); |
There was a problem hiding this comment.
this file was changed from prettier
|
Some lines were not covered as |
|
Looking into the format tests right now and trying to make them work |
Description
Fixes #7031
Coverage lines go up to 98%, the lines that are not covered is from formatters and that needs to be revisited and fixed to work as intended
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.