-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix format schema with list of objects #7040
Fix format schema with list of objects #7040
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 3a6d5d5 | Previous: 553f270 | Ratio |
---|---|---|---|
processingTx |
9147 ops/sec (±3.53% ) |
9223 ops/sec (±3.52% ) |
1.01 |
processingContractDeploy |
39517 ops/sec (±6.64% ) |
38080 ops/sec (±7.25% ) |
0.96 |
processingContractMethodSend |
19091 ops/sec (±7.37% ) |
19561 ops/sec (±4.97% ) |
1.02 |
processingContractMethodCall |
39226 ops/sec (±6.11% ) |
38511 ops/sec (±5.89% ) |
0.98 |
abiEncode |
43447 ops/sec (±6.29% ) |
43655 ops/sec (±6.63% ) |
1.00 |
abiDecode |
30125 ops/sec (±7.42% ) |
29655 ops/sec (±8.94% ) |
0.98 |
sign |
1534 ops/sec (±0.89% ) |
1555 ops/sec (±3.84% ) |
1.01 |
verify |
368 ops/sec (±3.15% ) |
371 ops/sec (±0.51% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7040 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 215 215
Lines 8296 8308 +12
Branches 2280 2287 +7
==========================================
+ Hits 7631 7642 +11
- Misses 665 666 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merging can you add unit tests so patch is passing.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6777
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.