Tests & ESLint Improvements #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avkos
requested review from
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
avkos
changed the title
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: c6bda35 | Previous: 6c075db | Ratio |
|---|---|---|---|
processingTx |
9183 ops/sec (±3.66%) |
9301 ops/sec (±4.81%) |
1.01 |
processingContractDeploy |
40187 ops/sec (±7.13%) |
39129 ops/sec (±7.62%) |
0.97 |
processingContractMethodSend |
19764 ops/sec (±7.06%) |
19443 ops/sec (±5.19%) |
0.98 |
processingContractMethodCall |
41026 ops/sec (±5.88%) |
38971 ops/sec (±6.34%) |
0.95 |
abiEncode |
45258 ops/sec (±7.43%) |
44252 ops/sec (±6.92%) |
0.98 |
abiDecode |
30831 ops/sec (±8.34%) |
30419 ops/sec (±8.89%) |
0.99 |
sign |
1561 ops/sec (±3.19%) |
1656 ops/sec (±4.08%) |
1.06 |
verify |
381 ops/sec (±0.46%) |
373 ops/sec (±0.78%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7012 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 215 215
Lines 8284 8287 +3
Branches 2273 2273
=======================================
+ Hits 7620 7623 +3
Misses 664 664
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
changed the title
luu-alex
reviewed
Apr 30, 2024
.github/workflows/build.yml
Outdated
| with: | ||
| path: ./ | ||
| key: web3-18-${{github.sha}} | ||
| - run: npx ts-node scripts/init.ts | ||
| # restore cache for each package from main branch | ||
| - name: Restore eslint caches | ||
| # if: github.event_name == 'push' && github.ref == 'refs/heads/4.x' |
There was a problem hiding this comment.
no. we need to restore everytime when we check. remove comment
packages/web3-core/package.json
Outdated
| "lint:fix": "eslint --fix --ext .js,.ts .", | ||
| "format": "prettier --write '**/*'", | ||
| "test": "jest --config=./test/unit/jest.config.js", | ||
| "test:coverage:unit": "jest --config=./test/unit/jest.config.js --coverage=true --coverage-reporters=text", | ||
| "test:coverage:unit": "jest --config=./test/unit/jest.config.js --coverage=true --coverage-reporters=text", |
There was a problem hiding this comment.
Suggested change
| "test:coverage:unit": "jest --config=./test/unit/jest.config.js --coverage=true --coverage-reporters=text", | |
| "test:coverage:unit": "jest --config=./test/unit/jest.config.js --coverage=true --coverage-reporters=text", |
There was a problem hiding this comment.
fixed in all packages
luu-alex
approved these changes
Apr 30, 2024
|
lgtm other than the comments ^ |
jdevcs
approved these changes
May 2, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6989
Results
LINT from 2m 10s to 44s (lint only changes, cache). locally - few seconds
UNIT from 3m 42s to 2m 48s (type check off)
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.