change default to data #6622
change default to data #6622
Conversation
Deploying with
|
| Latest commit: |
cd90d47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4681cbb3.web3-js-docs.pages.dev |
| Branch Preview URL: | https://change-default-data.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
luu-alex
requested review from
avkos,
jdevcs and
Muhammad-Altabba
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6622 +/- ##
==========================================
+ Coverage 89.36% 89.44% +0.07%
==========================================
Files 215 215
Lines 8309 8296 -13
Branches 2248 2241 -7
==========================================
- Hits 7425 7420 -5
+ Misses 884 876 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -79,7 +79,7 @@ export abstract class Web3Config | |||
| transactionConfirmationPollingInterval: undefined, | |||
| blockHeaderTimeout: 10, | |||
| maxListenersWarningThreshold: 100, | |||
| contractDataInputFill: 'input', | |||
| contractDataInputFill: 'data', | |||
There was a problem hiding this comment.
this will default to data for contracts package,
did you check directly using web3-eth sendTransaction? and also implicit usage of eth_call (for getting revert reason) in sendTransaction and sendRawTransaction?
There was a problem hiding this comment.
These methods both go through the web3-utils formatTransaction method web3-eth sendTransaction and call will only use whatever the user is sending (if the user sends data, it will be formatted using data, if user uses input they will use input).
So there is no change needed
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.