Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixing ERR_UNSUPPORTED_DIR_IMPORT in web3-eth-abi/lib/esm/coders/encode.js with node >18 #6537

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

kmlcnclk
Copy link
Contributor

@kmlcnclk kmlcnclk commented Oct 22, 2023

#6535 (Fixing this bug)

@kmlcnclk kmlcnclk changed the title Update encode.ts Bug Fixing https://github.com/web3/web3.js/issues/6535 Oct 22, 2023
@kmlcnclk kmlcnclk changed the title Bug Fixing https://github.com/web3/web3.js/issues/6535 Bug Fixing #6535 Oct 22, 2023
@kmlcnclk kmlcnclk changed the title Bug Fixing #6535 Bug Fixing ERR_UNSUPPORTED_DIR_IMPORT in web3-eth-abi/lib/esm/coders/encode.js with node >18 Oct 22, 2023
@luu-alex
Copy link
Contributor

#6535 (comment) include this as well, thanks

@0xApotheosis 0xApotheosis mentioned this pull request Oct 23, 2023
3 tasks
@kmlcnclk
Copy link
Contributor Author

kmlcnclk commented Oct 23, 2023

#6535 (comment) include this as well, thanks

I add them. You're welcome.

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmlcnclk also add in changelog , thanks

@kmlcnclk
Copy link
Contributor Author

@kmlcnclk also add in changelog , thanks

I did

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #6537 (bdd5d56) into 4.x (7bee9bc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bdd5d56 differs from pull request most recent head 4cdfcc2. Consider uploading reports for the commit 4cdfcc2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6537   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         215      215           
  Lines        8234     8234           
  Branches     2224     2224           
=======================================
  Hits         7384     7384           
  Misses        850      850           
Flag Coverage Δ
UnitTests 89.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

CHANGELOG.md Outdated
Comment on lines 1463 to 1466
#### web3-eth-abi

- Bug fix of `ERR_UNSUPPORTED_DIR_IMPORT` in ABI (#6535)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so sorry. I commit it now. Is it ok?

@jdevcs jdevcs merged commit a0d6730 into web3:4.x Oct 23, 2023
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants