-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fixing ERR_UNSUPPORTED_DIR_IMPORT in web3-eth-abi/lib/esm/coders/encode.js with node >18 #6537
Conversation
#6535 (comment) include this as well, thanks |
I add them. You're welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmlcnclk also add in changelog , thanks
I did |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6537 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 215 215
Lines 8234 8234
Branches 2224 2224
=======================================
Hits 7384 7384
Misses 850 850
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CHANGELOG.md
Outdated
#### web3-eth-abi | ||
|
||
- Bug fix of `ERR_UNSUPPORTED_DIR_IMPORT` in ABI (#6535) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmlcnclk not here, under https://github.com/web3/web3.js/blob/4.x/packages/web3/CHANGELOG.md#unreleased and https://github.com/web3/web3.js/blob/4.x/packages/web3-eth-abi/CHANGELOG.md#unreleased , so I merge this PR. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so sorry. I commit it now. Is it ok?
#6535 (Fixing this bug)