-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1/chore(web3-eth-accounts): bump @ethereumjs/common and @ethereumjs/tx #6457
Conversation
0843f17
to
23f0474
Compare
23f0474
to
4289f4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dnt merge external PRs with following changes:
-
dist/ build output
-
package-lock files, ( If changes in packagelock are necessary thn one of our team member will do these in another PR )
48e9316
to
4289f4c
Compare
Hi @legobeat |
Yes: To get the updates done in the updates in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @legobeat for your contribution,
Description
The versions of
@ethereumjs/
dependencies were pinned in #5529.This retains the pin (uncertain why it was first introduced) but bumps them to latest within semver-major.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.1.x
branch.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.