Canary releases #6143
Canary releases #6143
Conversation
Signed-off-by: Marin Petrunic <[email protected]>
mpetrunic
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba and
spacesailor24
as code owners
|
@jdevcs This needs NPM_TOKEN secret with npm registry automation token^^ |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
d71df33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://886b3d3f.web3-js-docs.pages.dev |
| Branch Preview URL: | https://canary-releases.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6143 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 197 197
Lines 7548 7548
Branches 2059 2059
=======================================
Hits 6595 6595
Misses 953 953
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for your great contribution @mpetrunic, |
package.json
Outdated
| @@ -91,7 +91,8 @@ | |||
| "test:blackbox:infura:ws": "yarn pre-blackbox && ./scripts/verdaccio.sh startBackgroundAndPublish && lerna run test:blackbox:infura:ws --stream && yarn post-blackbox", | |||
| "prepare": "husky install", | |||
| "postinstall": "yarn build", | |||
| "compile:contracts": "node ./scripts/compile_contracts.js && yarn format && yarn lint:fix" | |||
| "compile:contracts": "node ./scripts/compile_contracts.js && yarn format && yarn lint:fix", | |||
| "publish:canary": "lerna --canary --dist-tag dev --graph-type all --no-verify-access --yes" | |||
There was a problem hiding this comment.
Great contribution Marin,
if we dnt increment version # this will override existing dist version in npm, or will not able to push?
There was a problem hiding this comment.
Nope, so it will publish current [version].[commitsha] and it will tag that version with "dev" tag. It will never generate same version twice.
This will attach short commit sha to the version and it will put npm tag "dev" to the npm registry so you can either install with |
Signed-off-by: Marin Petrunic <[email protected]>
Done |
Signed-off-by: Marin Petrunic <[email protected]>
Signed-off-by: Marin Petrunic <[email protected]>
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.