Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.9.0 #5895

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Release/1.9.0 #5895

merged 6 commits into from
Mar 20, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Mar 7, 2023

Fixed

Changed

Security

@jdevcs jdevcs added the 1.x 1.0 related issues label Mar 7, 2023
@jdevcs jdevcs self-assigned this Mar 7, 2023
@jdevcs jdevcs added the Release label Mar 7, 2023
@coveralls
Copy link

coveralls commented Mar 7, 2023

Pull Request Test Coverage Report for Build 4470601938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 273 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 74.975%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 64.29%
packages/web3-core-helpers/src/formatters.js 9 83.86%
packages/web3-core-helpers/src/errors.js 31 1.47%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 40 40.3%
packages/web3-utils/src/utils.js 46 10.39%
packages/web3-eth-accounts/src/index.js 111 22.94%
Totals Coverage Status
Change from base Build 4469674625: 2.4%
Covered Lines: 3336
Relevant Lines: 4196

💛 - Coveralls

@jdevcs jdevcs marked this pull request as ready for review March 7, 2023 16:42
@jdevcs
Copy link
Contributor Author

jdevcs commented Mar 20, 2023

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@jdevcs
Copy link
Contributor Author

jdevcs commented Mar 20, 2023

synthetix


 4443 passing (1h)
  71 pending
  1 failing

  1) Contract: SupplySchedule
       functions and modifiers
         Given inflation amount of 800,000 - mintable supply
           should calculate the mintable supply as 0 within 1st week of inflation start date:
     Error: Time parameter
     
     

OZ

275 passing (16s)
  3 failing

  1) expectRevert
       expectRevert
         rejects a revert with incorrect expected reason:

      AssertionError: expected 'VM Exception while processing transac…' to equal 'Call to revert'
      + expected - actual

      -VM Exception while processing transaction: revert Call to revert
      +Call to revert
      
      at Context.<anonymous> (test/src/expectRevert.test.js:34:35)

  2) expectRevert
       assertion
         rejects an outOfGas:
     AssertionError: expect.fail()
      at assertFailure (test/helpers/assertFailure.js:9:10)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:123:7)

  3) expectRevert
       outOfGas
         accepts an outOfGas:

      Wrong kind of exception received
      + expected - actual

      -Transaction: 0x2ac43c339baaec32fc43c4d3b955696f738613626c504c7715e69c7a616e4ead exited with an error (status 0) after consuming all gas.
      -     Please check that the transaction:
      -     - satisfies all conditions set by Solidity `assert` statements.
      -     - has enough gas to execute the full transaction.
      -     - does not trigger an invalid opcode by other means (ex: accessing an array out of bounds).
      +out of gas
      
      at expectException (src/expectRevert.js:20:30)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:153:7)

     

These external repos test cases output is same like performed in last few releases.

@jdevcs jdevcs changed the title Release/1.9.0 RC.0 Release/1.9.0 Mar 20, 2023
@jdevcs
Copy link
Contributor Author

jdevcs commented Mar 20, 2023

merging 1.x into this release branch because #5932 merged in 1.x, for clean reference to release branch refer to 1 previous commit or v1.9.0 tag

@jdevcs
Copy link
Contributor Author

jdevcs commented Mar 20, 2023

we didn't do another RC due to #5932 because its minor change in github CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants