Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling correction API Reference -> Web3 -> utils #5758 Solved #5784

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Spelling correction API Reference -> Web3 -> utils #5758 Solved #5784

merged 3 commits into from
Jan 31, 2023

Conversation

Coollaitar
Copy link

@Coollaitar Coollaitar commented Jan 29, 2023 •
edited
Loading

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@Coollaitar
Spelling Mistake Corrected
d04be28 
Spelling correction API Reference -> Web3 -> utils
@Coollaitar
Merge pull request #1 from Coollaitar/Spelling-correction-API-Referen…
fff84df 
…ce-->-Web3-->-utils-web3#5758

Spelling Mistake Corrected
@Coollaitar Coollaitar closed this Jan 29, 2023
@Coollaitar Coollaitar reopened this Jan 29, 2023
@luu-alex
Copy link
Contributor

luu-alex commented Jan 30, 2023 •
edited
Loading

Edit: This will be included in the next release. Thanks!

@jdevcs jdevcs added the 1.x 1.0 related issues label Jan 31, 2023
@jdevcs jdevcs merged commit bcb918b into web3:1.x Jan 31, 2023
This was referenced Apr 10, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs jdevcs approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Coollaitar @luu-alex @jdevcs