Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unit tests & removed dead code for web3-providers-http (#5228) #5264

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Fixed unit tests & removed dead code for web3-providers-http (#5228) #5264

merged 2 commits into from
Jul 19, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 19, 2022

Description

This PR is for e2e win tests in CI of #5228

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Fixed unit tests & removed dead code for web3-providers-http (#5228)
2dabd15 
* Fixed unit tests & removed dead code for web3-providers-http

* Use chai-as-promised to resolve or reject promise

* Fixed bug that timeout option doesn't work properly
@jdevcs jdevcs self-assigned this Jul 19, 2022
@render
Copy link

render bot commented Jul 19, 2022

Your Render PR Server URL is https://web3-js-pr-5264.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cbb8f2r0tnuvdk1hmc90.

@jdevcs jdevcs marked this pull request as ready for review July 19, 2022 10:29
@coveralls
Copy link

coveralls commented Jul 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2696970239

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 443 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.1%) to 72.255%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-providers-http/lib/index.js 7 77.14%
packages/web3-core-helpers/src/formatters.js 25 80.95%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 96 13.31%
packages/web3-eth-accounts/src/index.js 166 23.62%
Totals Coverage Status
Change from base Build 2678847914: -2.1%
Covered Lines: 3402
Relevant Lines: 4432
💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 19, 2022

All code changes in this PR are approved in #5228 and tests are passing so merging in 1.x

@jdevcs jdevcs merged commit 84ac9b7 into 1.x Jul 19, 2022
@jdevcs jdevcs deleted the junaid/httpproviderfixtests branch July 19, 2022 10:50
@jdevcs jdevcs mentioned this pull request Jul 19, 2022
Merged
14 tasks
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 1, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2022
Closed
@lokera666 lokera666 mentioned this pull request Oct 11, 2022
Open
This was referenced Oct 23, 2022
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdevcs jdevcs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdevcs @coveralls