Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eth2 packages #3833

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Rename eth2 packages #3833

merged 2 commits into from
Jan 6, 2021

Conversation

spacesailor24
Copy link
Contributor

Description

Renames the packages:

  • web3-eth2-base to web3-eth2-core
  • web3-eth2-beacon to web3-eth2-beaconchain

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Jan 4, 2021

Coverage Status

Coverage remained the same at 80.423% when pulling 4b047ce on wyatt/rename-eth2-packages into e02374e on 1.x.

@GregTheGreek
Copy link
Contributor

Did you use git mv?

@spacesailor24
Copy link
Contributor Author

Did you use git mv?

Nope, didn't even know that existed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants