Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump websocket version #3704

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Bump websocket version #3704

merged 2 commits into from
Sep 1, 2020

Conversation

GregTheGreek
Copy link
Contributor

Description

This supersedes #3686 and addresses a major change to the websocket library that removes node-gyp.

Upon merge, web3.js no longer requires node-gyp, and therefore has increased install times.

Roughly speaking, ~40s speed increase.

Closes #3685

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Sep 1, 2020

Coverage Status

Coverage decreased (-2.4%) to 78.056% when pulling 1f6c3e4 on greg/bump-websocket into f33e5d5 on 1.x.

@GregTheGreek GregTheGreek merged commit 83691dd into 1.x Sep 1, 2020
@GregTheGreek GregTheGreek deleted the greg/bump-websocket branch September 1, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websocket's native dependencies
3 participants