-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade build process from gulp to webpack #3618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanio
added
Enhancement
Includes improvements or optimizations
1.x
1.0 related issues
labels
Jul 3, 2020
ryanio
force-pushed
the
upgrade-to-webpack
branch
from
July 3, 2020 18:50
c29f7c4
to
a9c0655
Compare
cgewecke
reviewed
Jul 6, 2020
cgewecke
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great improvement 🥇
Wrt dist/web3.min.js
...do we usually merge changes to that on release?
@cgewecke thanks! hm yes that makes sense to me, so i can remove it from this PR. edit: done |
ryanio
force-pushed
the
upgrade-to-webpack
branch
from
July 6, 2020 20:39
a9c0655
to
a049118
Compare
GregTheGreek
reviewed
Jul 6, 2020
GregTheGreek
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.x
1.0 related issues
Enhancement
Includes improvements or optimizations
Review Needed
Maintainer(s) need to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the build process from gulp/browserify to webpack.
This PR also:
npm run build-all
for creating sub-package browser builds.web3.min.js
is tested in both chrome and firefox with karma)webpack.config.js
and update theentry
andlibrary
to point to the sub-package you would like to build, then runnpm run build
.var
=>const
/let
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and tested the resulting files fromdist
folder in a browser.CHANGELOG.md
file in the root folder.