Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build process from gulp to webpack #3618

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Upgrade build process from gulp to webpack #3618

merged 2 commits into from
Jul 7, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Jul 3, 2020

Description

This PR upgrades the build process from gulp/browserify to webpack.

This PR also:

  • Removes npm run build-all for creating sub-package browser builds.
    • These builds weren't being published, and we aren't aware of many people using them.
    • They didn't have proper test coverage to ensure integrity of the builds (web3.min.js is tested in both chrome and firefox with karma)
    • It is now easy for anyone to create a browser build of a sub-package with this PR. Just modify the root webpack.config.js and update the entry and library to point to the sub-package you would like to build, then run npm run build.
  • Updates some root deps and removes old/unneeded ones
  • Updates readmes var => const/let

Type of change

  • build process enhancements (non-breaking change)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.

@ryanio ryanio added Enhancement Includes improvements or optimizations 1.x 1.0 related issues labels Jul 3, 2020
@ryanio ryanio marked this pull request as draft July 3, 2020 18:29
@ryanio ryanio marked this pull request as ready for review July 3, 2020 18:58
@ryanio ryanio added the Review Needed Maintainer(s) need to review label Jul 3, 2020
@coveralls
Copy link

coveralls commented Jul 3, 2020

Coverage Status

Coverage remained the same at 90.166% when pulling a049118 on upgrade-to-webpack into 1404086 on 1.x.

@ryanio ryanio requested a review from cgewecke July 6, 2020 18:38
package.json Show resolved Hide resolved
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great improvement 🥇

Wrt dist/web3.min.js...do we usually merge changes to that on release?

@ryanio
Copy link
Collaborator Author

ryanio commented Jul 6, 2020

@cgewecke thanks! hm yes that makes sense to me, so i can remove it from this PR. edit: done

@ryanio ryanio merged commit 4e36583 into 1.x Jul 7, 2020
@ryanio ryanio mentioned this pull request Jul 9, 2020
14 tasks
@ryanio ryanio mentioned this pull request Jul 24, 2020
4 tasks
@GregTheGreek GregTheGreek deleted the upgrade-to-webpack branch July 26, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants