Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for transactionPollingTimeout #3533

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Add tests for transactionPollingTimeout #3533

merged 6 commits into from
Jun 2, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented May 21, 2020

Description

#3513

Adds some tests to verify the transactionPollingTimeout threshold is configurable for both web3.eth and contract methods and works as expected with geth interval mining.

Adds examples for the method configuration settings to the docs. In #3513 there was uncertainty about how the polling limit should be set since it seemed like it's not working.

(DRAFT: am requesting @miohtama for further review here because these (unsuccessfully) try to reproduce the config failure reported in #3513)

Type of change

  • Tests

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented May 21, 2020

Coverage Status

Coverage increased (+0.09%) to 89.732% when pulling 159cd79 on issue/3513 into a434ce1 on 1.x.

@cgewecke cgewecke marked this pull request as ready for review May 29, 2020 13:14
@cgewecke cgewecke added Documentation Relates to project wiki or documentation Review Needed Maintainer(s) need to review labels May 29, 2020
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@cgewecke cgewecke merged commit 816af22 into 1.x Jun 2, 2020
@cgewecke cgewecke deleted the issue/3513 branch June 2, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants