Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix newline in sendTransaction note #3518

Merged
merged 1 commit into from
May 13, 2020
Merged

Docs: fix newline in sendTransaction note #3518

merged 1 commit into from
May 13, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 12, 2020 •
edited
Loading

Description

The "Note" in the docs for sendTransaction has a newline in its last sentence that breaks its formatting.

Screenshot:

Screen Shot 2020-05-12 at 3 44 29 PM

This PR simply removes the newline.

Type of change

  • Docs fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@ryanio ryanio added Documentation Relates to project wiki or documentation 1.x 1.0 related issues labels May 12, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.555% when pulling 17040f0 on fixSendTxDocsNote into dd4c8ec on 1.x.

@cgewecke cgewecke self-requested a review May 13, 2020 16:08
cgewecke
cgewecke approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ryanio ryanio merged commit 137ca7b into 1.x May 13, 2020
@cgewecke cgewecke mentioned this pull request Jun 18, 2020
Closed
@baby636 baby636 mentioned this pull request Jun 23, 2023
Open
@mpetrunic mpetrunic deleted the fixSendTxDocsNote branch October 31, 2023 13:36
@adamlaska adamlaska mentioned this pull request Dec 20, 2023
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@baby636 baby636 mentioned this pull request Feb 12, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 12, 2024
Open
@baby636 baby636 mentioned this pull request Mar 23, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 23, 2024
Open
@adamlaska adamlaska mentioned this pull request May 13, 2024
Open
@baby636 baby636 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanio @coveralls @cgewecke