receipt is missing on error event #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
added
Bug
|
@cgewecke We have to add the error cases in the |
cgewecke
reviewed
Oct 15, 2019
cgewecke
reviewed
Oct 15, 2019
cgewecke
reviewed
Oct 15, 2019
Co-Authored-By: cgewecke <[email protected]>
Co-Authored-By: cgewecke <[email protected]>
cgewecke
reviewed
Oct 15, 2019
There was a problem hiding this comment.
Looks good!
Perhaps we should open an issue considering the suggestion in this comment, about restoring a generic emitter for any receipt, regardless of status.
cgewecke
approved these changes
Oct 15, 2019
Co-Authored-By: cgewecke <[email protected]>
This was referenced Mar 31, 2020
This was referenced Apr 1, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* receipt added for error event listener on sending of a transaction * packages updated in package-lock because of security warnings from npm * passing of parameters to _fireError updated in Method object of the web3-core-method module * CHANGELOG.md updated * documentation for sendTransaction and contract.methods.myMethod.send() updated * Update packages/web3-core-method/src/index.js Co-Authored-By: cgewecke <[email protected]> * Update docs/web3-eth.rst Co-Authored-By: cgewecke <[email protected]> * wrongly passed parameters for the _fireError function fixed * Update docs/web3-eth-contract.rst Co-Authored-By: cgewecke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1859 with adding of the receipt to the returned values of the error event listener. The receipt will get returned if not enough gas was provided or the EVM is reverting the transaction on other contract-specific reasons.